Re: [PATCH 5/7] perf tools: Pass struct perf_hpp_fmt to its callbacks

[Namhyung Kim <namhyung@kernel.org>]

Hi Arnaldo and Jiri,

On Mon, Jan 12, 2015 at 01:44:06PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 12, 2015 at 05:40:50PM +0100, Jiri Olsa escreveu:
> > On Mon, Jan 12, 2015 at 01:27:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Mon, Jan 12, 2015 at 01:21:40PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > > Em Thu, Jan 08, 2015 at 09:45:46AM +0900, Namhyung Kim escreveu:
> > > > > Currently ->cmp, ->collapse and ->sort callbacks doesn't pass
> > > > > corresponding fmt.  But it'll be needed by upcoming changes in
> > > > > perf diff command.
> > > > > 
> > > > > Suggested-by: Jiri Olsa <jolsa@kernel.org>
> > > > 
> > > > 
> > > >   CC       /tmp/build/perf/builtin-evlist.o
> > > > builtin-diff.c: In function ‘data__hpp_register’:
> > > > builtin-diff.c:1036:11: error: assignment from incompatible pointer type [-Werror]
> > > >   fmt->cmp    = hist_entry__cmp_nop;
> > > >            ^
> > > > builtin-diff.c:1037:16: error: assignment from incompatible pointer type [-Werror]
> > > >   fmt->collapse = hist_entry__cmp_nop;
> > > >                 ^
> > > > builtin-diff.c:1043:13: error: assignment from incompatible pointer type [-Werror]
> > > >    fmt->sort  = hist_entry__cmp_baseline;
> > > >              ^
> > > > builtin-diff.c:1047:13: error: assignment from incompatible pointer type [-Werror]
> > > >    fmt->sort  = hist_entry__cmp_delta;
> > > >              ^
> > > > builtin-diff.c:1051:13: error: assignment from incompatible pointer type [-Werror]
> > > >    fmt->sort  = hist_entry__cmp_ratio;
> > > >              ^
> > > > builtin-diff.c:1055:13: error: assignment from incompatible pointer type [-Werror]
> > > >    fmt->sort  = hist_entry__cmp_wdiff;
> > > >              ^
> > > > builtin-diff.c:1058:13: error: assignment from incompatible pointer type [-Werror]
> > > >    fmt->sort  = hist_entry__cmp_nop;
> > > >              ^
> > > > cc1: all warnings being treated as errors
> > > >   LINK     plugin_kvm.so
> > > > make[1]: *** [/tmp/build/perf/builtin-diff.o] Error 1
> > > > make[1]: *** Waiting for unfinished jobs....
> > > >   LINK     plugin_mac80211.so
> > > 
> > > Am I missing something? Lemme continue trying applying the rest of the
> > > kit...
> > 
> > hum,
> > looks like those (= hist_entry__cmp_delta,.. functions) are fixed (=added fmt param)
> > later in patch 6/7 of this series.. which is wrong, should be updated in this patch,
> > as you did below
> 
> I have it all fixed up and pushed to my perf/core branch, thanks for
> checking!

Oops, my bad.  It must came from the many of rebases during the
development.  Sorry about that and really thank you to fix them up.

Thanks,
Namhyung