From: Baruch Siach <baruch@tkos.co.il>
To: Arnd Bergmann <arnd@arndb.de>
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: digicolor: fix sysrq handling
Date: Wed, 14 Jan 2015 07:57:01 +0200 [thread overview]
Message-ID: <20150114055701.GX2481@sapphire.tkos.co.il> (raw)
In-Reply-To: <1730002.vWGOEymGdz@wuerfel>
Hi Arnd,
On Tue, Jan 13, 2015 at 03:37:11PM +0100, Arnd Bergmann wrote:
> Trying to build the digicolor-usart driver when sysrq is disabled
> results in a compile error:
>
> drivers/tty/serial/digicolor-usart.c: In function 'digicolor_uart_console_write':
> drivers/tty/serial/digicolor-usart.c:407:33: error: 'struct uart_port' has no member named 'sysrq'
>
> Like a lot of other drivers, this one requires an #ifdef to avoid
> accessing the sysrq field here. While looking into this, I noticed
> that the case where sysrq support is enabled is also broken, because
> the driver fails to set the SUPPORT_SYSRQ macro.
>
> This patch hopefully fixes both, but I do not hardware to test if sysrq
> is actually working now.
Unfortunately the hardware is not able to detect the BREAK condition, so it is
not possible to support sysrq on this hardware. I'll send a patch removing
sysrq reference.
Thanks for build testing and reporting.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-01-14 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 14:37 [PATCH] serial: digicolor: fix sysrq handling Arnd Bergmann
2015-01-14 5:57 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114055701.GX2481@sapphire.tkos.co.il \
--to=baruch@tkos.co.il \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).