From: Peter Stuge <peter@stuge.se>
To: Mark Glover <mark@actisense.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added PIDs for Actisense USB Devices Signed-off-by: Mark Glover <mark@actisense.com>
Date: Wed, 14 Jan 2015 13:52:19 +0100 [thread overview]
Message-ID: <20150114125220.32654.qmail@stuge.se> (raw)
In-Reply-To: <1421238314-2974-1-git-send-email-mark@actisense.com>
Please update your commit message to leave one blank line between the
commit message summary and the rest of the message. (This avoids your
signed-off-by ending up in the email subject.)
Mark Glover wrote:
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
..
> +#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */
> +#define CHETCO_SEAGAUGE__PID 0xA549 /* SeaSwitch USG Apadter */
Please make the macro name match the product name. Also note typo^ here.
//Peter
prev parent reply other threads:[~2015-01-14 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 12:25 [PATCH] Added PIDs for Actisense USB Devices Signed-off-by: Mark Glover <mark@actisense.com> Mark Glover
2015-01-14 12:52 ` Peter Stuge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114125220.32654.qmail@stuge.se \
--to=peter@stuge.se \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark@actisense.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox