From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Felipe Tonello <eu@felipetonello.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] char: Added support for u-blox 6 i2c gps driver
Date: Wed, 14 Jan 2015 12:43:30 -0800 [thread overview]
Message-ID: <20150114204330.GB31119@kroah.com> (raw)
In-Reply-To: <CAGrhNMysmq==Y0naNki0z5usmMwUErj-FOTy=8KH0V=R7=VFwA@mail.gmail.com>
On Wed, Jan 14, 2015 at 10:39:04AM -0800, Felipe Tonello wrote:
> The thing is that: I wrote this driver to work with only one gps
> module, because that's my configuration here. I cannot really test
> multiple i2c gps at the same time. If you guys really want a driver
> that works for multiple gps drivers, I cannot test it.
>
> So my question is, can I leave the driver working for one gps only and
> then improve what needs to be improved?
No, write it to handle any number of devices, the logic is the same for
one, or one thousand, there should not be any issues in the driver that
make this any different.
thanks,
greg k-h
next prev parent reply other threads:[~2015-01-14 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 1:16 [PATCH] char: Added support for u-blox 6 i2c gps driver Felipe F. Tonello
2015-01-14 1:33 ` Greg Kroah-Hartman
2015-01-14 2:07 ` Felipe Tonello
2015-01-14 4:10 ` Greg Kroah-Hartman
2015-01-14 15:48 ` One Thousand Gnomes
2015-01-14 18:39 ` Felipe Tonello
2015-01-14 20:43 ` Greg Kroah-Hartman [this message]
2015-01-15 11:29 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114204330.GB31119@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=eu@felipetonello.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox