From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754335AbbAPA2i (ORCPT ); Thu, 15 Jan 2015 19:28:38 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:59723 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbbAPA2g (ORCPT ); Thu, 15 Jan 2015 19:28:36 -0500 Date: Thu, 15 Jan 2015 18:28:02 -0600 From: Bjorn Helgaas To: Alex Williamson Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] PCI: Reset exclusions Message-ID: <20150116002802.GE29776@google.com> References: <20141121180322.26669.65689.stgit@gimli.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141121180322.26669.65689.stgit@gimli.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 21, 2014 at 11:24:02AM -0700, Alex Williamson wrote: > This is really 2 sets of 2 patches, but they both add bits to > dev_flags so are included together. > > This fixes two problems we've seen with resets. The first is for > devices that advertise a PM reset mechanism, but it doesn't appear to > do anything. We add a quirk and flags bit to indicate the PM reset > mechanism isn't viable. This happens on some AMD GPUs and causes > vfio-pci to assume the PM reset was successful when it really did > nothing and we should have escalated to a PCI bus reset. Alex > Deucher confirms that PM reset isn't used by graphics drivers. The > exclusion here is for users of pci_reset_function(), which mostly > only includes pci-sysfs and drivers like legacy KVM device assignment > and VFIO. > > The second issue is a problem identified with an Atheros wifi chip > where in performing a bus reset of the device, we not only permanently > lose access to the device, but it introduces host stability issues if > we try to access it. I've been unsuccessful in finding any way to > make the device behave or in finding anyone with access to hardware > documentation and errata for this device, so it seems like the most > appropriate path is to blacklist bus resets for topologies including > this device. The second two patches add infrastructure and quirks to > do this. Thanks, > > Alex > > --- > > Alex Williamson (4): > PCI: quirk Atheros AR93xx to avoid bus reset > PCI: Allow device quirks to exclude bus reset I applied these two (above) to for-linus for v3.19, thanks. > PCI: quirk AMD/ATI VGA cards to avoid PM reset > PCI: Allow device quirks to exclude D3->D0 PM reset > > > drivers/pci/pci.c | 42 +++++++++++++++++++++++++++++++++++++----- > drivers/pci/quirks.c | 35 +++++++++++++++++++++++++++++++++++ > include/linux/pci.h | 4 ++++ > 3 files changed, 76 insertions(+), 5 deletions(-)