From: Dan Carpenter <dan.carpenter@oracle.com>
To: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
dsd@laptop.org, jfrederich@gmail.com, gregkh@linuxfoundation.org,
jon.nettleton@gmail.com
Subject: Re: [PATCH 1/2] staging: olpc_dcon: check for CONFIG_OLPC before calling olpc_board_at_least()
Date: Fri, 16 Jan 2015 13:20:29 +0300 [thread overview]
Message-ID: <20150116102029.GE6201@mwanda> (raw)
In-Reply-To: <1421373300-13672-2-git-send-email-mopsfelder@gmail.com>
On Thu, Jan 15, 2015 at 11:54:59PM -0200, Murilo Opsfelder Araujo wrote:
> The following error messages are thrown by sparse when CONFIG_OLPC is
> not defined:
>
> drivers/staging/olpc_dcon/olpc_dcon.c:147:17: error: undefined identifier 'olpc_board_at_least'
> drivers/staging/olpc_dcon/olpc_dcon.c:208:14: error: undefined identifier 'olpc_board_at_least'
>
> This patch fixes these errors.
Don't add ifdefs to a .c file. Don't call BUG_ON() in a driver.
Figure out a better way to fix these.
regards,
dan carpenter
next prev parent reply other threads:[~2015-01-16 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 1:54 [PATCH 0/2] staging: olpc_dcon: fix sparse warnings and compile errors Murilo Opsfelder Araujo
2015-01-16 1:54 ` [PATCH 1/2] staging: olpc_dcon: check for CONFIG_OLPC before calling olpc_board_at_least() Murilo Opsfelder Araujo
2015-01-16 10:20 ` Dan Carpenter [this message]
2015-01-16 1:55 ` [PATCH 2/2] staging: olpc_dcon: fix sparse symbol not declared warning Murilo Opsfelder Araujo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116102029.GE6201@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dsd@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mopsfelder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox