From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748AbbAPKsJ (ORCPT ); Fri, 16 Jan 2015 05:48:09 -0500 Received: from down.free-electrons.com ([37.187.137.238]:33147 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751858AbbAPKsH (ORCPT ); Fri, 16 Jan 2015 05:48:07 -0500 Date: Fri, 16 Jan 2015 11:48:04 +0100 From: Alexandre Belloni To: Daniel Lezcano Cc: Thomas Gleixner , John Stultz , Nicolas Ferre , Boris Brezillon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 2/2] clocksource: don't suspend/resume when unused Message-ID: <20150116104804.GE3843@piout.net> References: <1421399874-29119-1-git-send-email-alexandre.belloni@free-electrons.com> <1421399874-29119-3-git-send-email-alexandre.belloni@free-electrons.com> <20150116103530.GB3843@piout.net> <54B8EA54.5020002@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B8EA54.5020002@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 16/01/2015 at 11:39:16 +0100, Daniel Lezcano wrote : > >Isn't that already the case? > >Right now, if you call clocksource_suspend, it doesn't matter whether > >the clocksource has an enable or not, it will be suspended. Maybe I'm > >mistaken but my patch doesn't seem to change that behaviour. > > Actually, if there is no enable/disable callback, then CLOCK_SOURCE_USED > will be never set, hence the condition will always fail and the suspend > callback won't be called. > It is set in clocksource_enable/disable, even if there is no enable/disable callback. I only found direct calls to ->enable() in timekeeper.c, did I miss some? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com