linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
Cc: gregkh@linuxfoundation.org, mark.rutland@arm.com, arnd@arndb.de,
	gnomes@lxorguk.ukuu.org.uk, broonie@kernel.org,
	robh+dt@kernel.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	will.deacon@arm.com, catalin.marinas@arm.com, jslaby@suse.cz,
	jason@lakedaemon.net, heiko@sntech.de, florian.vaussard@epfl.ch,
	andrew@lunn.ch, rrichter@cavium.com, hytszk@gmail.com,
	grant.likely@linaro.org, antonynpavlov@gmail.com,
	Joel.Schopp@amd.com, Suravee.Suthikulpanit@amd.com,
	shawn.guo@linaro.org, lea.yan@linaro.org,
	jorge.ramirez-ortiz@linaro.org, lee.jones@linaro.org,
	orsonzhai@gmail.com, geng.ren@spreadtrum.com,
	zhizhou.zhang@spreadtrum.com, lanqing.liu@spreadtrum.com,
	zhang.lyra@gmail.com, wei.qiao@spreadtrum.com,
	devicetree@vger.kernel.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support
Date: Fri, 16 Jan 2015 13:02:09 +0200	[thread overview]
Message-ID: <20150116110209.GA2299@tarshish> (raw)
In-Reply-To: <1421402411-3479-6-git-send-email-chunyan.zhang@spreadtrum.com>

Hi Chunyan Zhang,

On Fri, Jan 16, 2015 at 06:00:11PM +0800, Chunyan Zhang wrote:
> +		if (uart_handle_sysrq_char(port, ch))
> +			continue;

You don't define SUPPORT_SYSRQ, so uart_handle_sysrq_char has no effect. See 
include/linux/serial_core.h.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  parent reply	other threads:[~2015-01-16 11:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <sc9836-v5>
2015-01-16 10:00 ` [PATCH v5 0/5] Add Spreadtrum Sharkl64 Platform support Chunyan Zhang
2015-01-16 10:00   ` [PATCH v5 1/5] Documentation: DT: Renamed of-serial.txt to 8250.txt Chunyan Zhang
2015-01-16 14:11     ` Rob Herring
2015-01-16 10:00   ` [PATCH v5 2/5] Documentation: DT: Add bindings for Spreadtrum SoC Platform Chunyan Zhang
2015-01-16 10:21     ` Mark Rutland
2015-01-16 12:53       ` Lyra Zhang
2015-01-16 14:11         ` Mark Rutland
2015-01-17  8:10           ` Orson Zhai
2015-01-16 10:00   ` [PATCH v5 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC in dts and Makefile Chunyan Zhang
2015-01-16 10:35     ` Mark Rutland
2015-01-16 12:49       ` Orson Zhai
2015-01-16 14:09         ` Mark Rutland
2015-01-17  8:47           ` Orson Zhai
2015-01-16 10:00   ` [PATCH v5 4/5] arm64: Add support for Spreadtrum's Sharkl64 Platform in Kconfig and defconfig Chunyan Zhang
2015-01-16 10:48     ` Mark Rutland
2015-01-16 11:50       ` Lyra Zhang
2015-01-16 10:00   ` [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support Chunyan Zhang
2015-01-16 10:26     ` Arnd Bergmann
2015-01-16 11:02     ` Baruch Siach [this message]
2015-01-16 15:20     ` Peter Hurley
2015-01-20 12:11       ` Orson Zhai
2015-01-20 13:39         ` Peter Hurley
2015-01-16 16:41     ` Rob Herring
2015-01-19  9:55       ` Lyra Zhang
2015-01-19 14:11         ` Rob Herring
2015-01-20  7:37           ` Lyra Zhang
2015-01-20  8:41             ` Orson Zhai
2015-01-20 20:17             ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150116110209.GA2299@tarshish \
    --to=baruch@tkos.co.il \
    --cc=Joel.Schopp@amd.com \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=andrew@lunn.ch \
    --cc=antonynpavlov@gmail.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=chunyan.zhang@spreadtrum.com \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.vaussard@epfl.ch \
    --cc=galak@codeaurora.org \
    --cc=geng.ren@spreadtrum.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=hytszk@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=jslaby@suse.cz \
    --cc=lanqing.liu@spreadtrum.com \
    --cc=lea.yan@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=orsonzhai@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rrichter@cavium.com \
    --cc=shawn.guo@linaro.org \
    --cc=wei.qiao@spreadtrum.com \
    --cc=will.deacon@arm.com \
    --cc=zhang.lyra@gmail.com \
    --cc=zhizhou.zhang@spreadtrum.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).