From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbbAQWB1 (ORCPT ); Sat, 17 Jan 2015 17:01:27 -0500 Received: from mail-pd0-f175.google.com ([209.85.192.175]:51372 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbbAQWB0 convert rfc822-to-8bit (ORCPT ); Sat, 17 Jan 2015 17:01:26 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Sergei Shtylyov , linux-kernel@vger.kernel.org, sboyd@codeaurora.org From: Mike Turquette In-Reply-To: <2500887.6mMDBajo0S@wasted.cogentembedded.com> Cc: linux-sh@vger.kernel.org References: <2500887.6mMDBajo0S@wasted.cogentembedded.com> Message-ID: <20150117220116.22722.808@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH] clk-gate: fix bit # check in clk_register_gate() Date: Sat, 17 Jan 2015 14:01:16 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sergei Shtylyov (2014-12-24 06:43:27) > In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit # > should be no higher than 15, however the corresponding check is obviously off- > by-one. > > Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK") > Signed-off-by: Sergei Shtylyov Applied to clk-next. Thanks! Is this causing a visible regression for you? It is not a new bug so I'd prefer to send it though clk-next unless something is blowing up on your end. > > --- > The patch is against Linus' repo because the 'clk-fixes' branch in Mike > Turquette's 'linux.git' repo at Linaro seems very outdated. BTW, the repo > at kernel.org specified by the MAINTAINERS file doesn't seem to exist -- > can something be done about that? The clk-fixes branch at git.linaro.org is now updated and the clk tree at git.kernel.org is also live. Blame the holidays. For now they will mirror each other (and linux-next will continue to reference the one at git.linaro.org until 3.19 is released). Regards, Mike > > drivers/clk/clk-gate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/drivers/clk/clk-gate.c > =================================================================== > --- linux.orig/drivers/clk/clk-gate.c > +++ linux/drivers/clk/clk-gate.c > @@ -128,7 +128,7 @@ struct clk *clk_register_gate(struct dev > struct clk_init_data init; > > if (clk_gate_flags & CLK_GATE_HIWORD_MASK) { > - if (bit_idx > 16) { > + if (bit_idx > 15) { > pr_err("gate bit exceeds LOWORD field\n"); > return ERR_PTR(-EINVAL); > } >