Re: [PATCH] staging: skein: Fix checkpatch warnings

Greg KH
2015-01-17T23:37:50Z

On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote:
> Remove do {} while (0) loops around single statements in
> skein/skein_block.c
>
> Signed-off-by: Arno Tiemersma <arno.tiemersma@gmail.com>
> ---
> drivers/staging/skein/skein_block.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
> index 66261ab..39dccf8 100644
> --- a/drivers/staging/skein/skein_block.c
> +++ b/drivers/staging/skein/skein_block.c
> @@ -83,9 +83,7 @@ do { \
> #else
> /* looping version */
> #define R256(p0, p1, p2, p3, ROT, r_num) \
> -do { \
> - ROUND256(p0, p1, p2, p3, ROT, r_num); \
> -} while (0)
> + ROUND256(p0, p1, p2, p3, ROT, r_num)
>
> #define I256(R) \
> do { \
> @@ -174,9 +172,7 @@ do { \
>
> #else /* looping version */
> #define R512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num) \
> -do { \
> - ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num); \
> -} while (0)
> + ROUND512(p0, p1, p2, p3, p4, p5, p6, p7, ROT, r_num)
>
> #define I512(R) \
> do { \
> @@ -263,10 +259,8 @@ do { \
> #if SKEIN_UNROLL_1024 == 0
> #define R1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, pF, \
> ROT, rn) \
> -do { \
> ROUND1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, \
> - pF, ROT, rn); \
> -} while (0)
> + pF, ROT, rn)
>
> #define I1024(R) \
> do { \
> @@ -291,10 +285,8 @@ do { \
> #else /* looping version */
> #define R1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, pF, \
> ROT, rn) \
> -do { \
> ROUND1024(p0, p1, p2, p3, p4, p5, p6, p7, p8, p9, pA, pB, pC, pD, pE, \
> - pF, ROT, rn); \
> -} while (0)
> + pF, ROT, rn)
>
> #define I1024(R) \
> do { \
> --
> 2.1.0
>

Doesn't apply to my tree :(