* [PATCH] Staging: wlan-ng: hfa384x_usb: Fix else is not useful warning
@ 2015-01-08 14:01 Sven Dziadek
2015-01-18 0:11 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sven Dziadek @ 2015-01-08 14:01 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
This fixes the following checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Sven Dziadek <sven.dziadek@gmx.de>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 55d2f56..a9a5649 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -4123,12 +4123,11 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
pdrcode);
return 1;
- } else {
- /* bad code */
- pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
- pdrcode);
- return 0;
}
+ /* bad code */
+ pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+ pdrcode);
+ return 0;
}
return 0; /* avoid compiler warnings */
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fix else is not useful warning
2015-01-08 14:01 [PATCH] Staging: wlan-ng: hfa384x_usb: Fix else is not useful warning Sven Dziadek
@ 2015-01-18 0:11 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-01-18 0:11 UTC (permalink / raw)
To: Sven Dziadek; +Cc: devel, linux-kernel
On Thu, Jan 08, 2015 at 03:01:17PM +0100, Sven Dziadek wrote:
> This fixes the following checkpatch.pl warning:
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Sven Dziadek <sven.dziadek@gmx.de>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Someone else sent this same change before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-18 0:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-08 14:01 [PATCH] Staging: wlan-ng: hfa384x_usb: Fix else is not useful warning Sven Dziadek
2015-01-18 0:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox