* [PATCH] Staging: slicoss: Fix long line issues in slicoss.c
@ 2014-12-02 23:45 Sean Cleator
2014-12-03 6:08 ` Sudip Mukherjee
0 siblings, 1 reply; 4+ messages in thread
From: Sean Cleator @ 2014-12-02 23:45 UTC (permalink / raw)
To: gregkh
Cc: Lior Dotan, Christopher Harrer, David Matlack, Monam Agarwal,
Paul E. McKenney, Joe Perches, Sean Cleator, Vincent Heuken,
devel, linux-kernel
A patch to the slicoss.c file to fix some of the long line issues found by the
checkpath.pl tool
Signed-off-by: Sean Cleator <seancleator@hotmail.co.uk>
---
drivers/staging/slicoss/slicoss.c | 39 ++++++++++++++++++++++++++-------------
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 56ca3b6..4df4a7e 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -498,12 +498,14 @@ static int slic_card_download(struct adapter *adapter)
slic_reg32_write(&slic_regs->slic_wcs,
baseaddress + codeaddr, FLUSH);
/* Write out instruction to low addr */
- slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
+ slic_reg32_write(&slic_regs->slic_wcs,
+ instruction, FLUSH);
instruction = *(u32 *)(fw->data + index);
index += 4;
/* Write out instruction to high addr */
- slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
+ slic_reg32_write(&slic_regs->slic_wcs,
+ instruction, FLUSH);
instruction = *(u32 *)(fw->data + index);
index += 4;
}
@@ -1533,14 +1535,18 @@ retry_rcvqfill:
dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
__func__);
dev_err(dev, "skb[%p] PROBLEM\n", skb);
- dev_err(dev, " skbdata[%p]\n", skb->data);
+ dev_err(dev, " skbdata[%p]\n",
+ skb->data);
dev_err(dev, " skblen[%x]\n", skb->len);
dev_err(dev, " paddr[%p]\n", paddr);
dev_err(dev, " paddrl[%x]\n", paddrl);
dev_err(dev, " paddrh[%x]\n", paddrh);
- dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
- dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
- dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
+ dev_err(dev, " rcvq->head[%p]\n",
+ rcvq->head);
+ dev_err(dev, " rcvq->tail[%p]\n",
+ rcvq->tail);
+ dev_err(dev, " rcvq->count[%x]\n",
+ rcvq->count);
dev_err(dev, "SKIP THIS SKB!!!!!!!!\n");
goto retry_rcvqfill;
}
@@ -1549,14 +1555,18 @@ retry_rcvqfill:
dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
__func__);
dev_err(dev, "skb[%p] PROBLEM\n", skb);
- dev_err(dev, " skbdata[%p]\n", skb->data);
+ dev_err(dev, " skbdata[%p]\n",
+ skb->data);
dev_err(dev, " skblen[%x]\n", skb->len);
dev_err(dev, " paddr[%p]\n", paddr);
dev_err(dev, " paddrl[%x]\n", paddrl);
dev_err(dev, " paddrh[%x]\n", paddrh);
- dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
- dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
- dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
+ dev_err(dev, " rcvq->head[%p]\n",
+ rcvq->head);
+ dev_err(dev, " rcvq->tail[%p]\n",
+ rcvq->tail);
+ dev_err(dev, " rcvq->count[%x]\n",
+ rcvq->count);
dev_err(dev, "GIVE TO CARD ANYWAY\n");
}
#endif
@@ -1885,7 +1895,8 @@ static void slic_xmit_fail(struct adapter *adapter,
break;
case XMIT_FAIL_HOSTCMD_FAIL:
dev_err(&adapter->netdev->dev,
- "xmit_start skb[%p] type[%x] No host commands available\n", skb, skb->pkt_type);
+ "xmit_start skb[%p] type[%x] No host commands available\n",
+ skb, skb->pkt_type);
break;
}
}
@@ -2097,7 +2108,8 @@ static void slic_interrupt_card_up(u32 isr, struct adapter *adapter,
}
} else if (isr & ISR_XDROP) {
dev_err(&dev->dev,
- "isr & ISR_ERR [%x] ISR_XDROP\n", isr);
+ "isr & ISR_ERR [%x] ISR_XDROP\n",
+ isr);
} else {
dev_err(&dev->dev,
"isr & ISR_ERR [%x]\n",
@@ -2341,7 +2353,8 @@ static int slic_if_init(struct adapter *adapter)
SLIC_GET_ADDR_LOW(&pshmem->isr), FLUSH);
#else
slic_reg32_write(&slic_regs->slic_addr_upper, 0, DONT_FLUSH);
- slic_reg32_write(&slic_regs->slic_isp, (u32)&pshmem->isr, FLUSH);
+ slic_reg32_write(&slic_regs->slic_isp, (u32)&pshmem->isr,
+ FLUSH);
#endif
spin_unlock_irqrestore(&adapter->bit64reglock.lock,
adapter->bit64reglock.flags);
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c
2014-12-02 23:45 Sean Cleator
@ 2014-12-03 6:08 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2014-12-03 6:08 UTC (permalink / raw)
To: Sean Cleator
Cc: gregkh, Lior Dotan, Christopher Harrer, David Matlack,
Monam Agarwal, Paul E. McKenney, Joe Perches, Vincent Heuken,
devel, linux-kernel
On Tue, Dec 02, 2014 at 11:45:00PM +0000, Sean Cleator wrote:
>
> A patch to the slicoss.c file to fix some of the long line issues found by the
> checkpath.pl tool
> Signed-off-by: Sean Cleator <seancleator@hotmail.co.uk>
do not use whitespace before Signed-off-by
thanks
sudip
>
> ---
> drivers/staging/slicoss/slicoss.c | 39 ++++++++++++++++++++++++++-------------
> 1 file changed, 26 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 56ca3b6..4df4a7e 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -498,12 +498,14 @@ static int slic_card_download(struct adapter *adapter)
> slic_reg32_write(&slic_regs->slic_wcs,
> baseaddress + codeaddr, FLUSH);
> /* Write out instruction to low addr */
> - slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
> + slic_reg32_write(&slic_regs->slic_wcs,
> + instruction, FLUSH);
> instruction = *(u32 *)(fw->data + index);
> index += 4;
>
> /* Write out instruction to high addr */
> - slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
> + slic_reg32_write(&slic_regs->slic_wcs,
> + instruction, FLUSH);
> instruction = *(u32 *)(fw->data + index);
> index += 4;
> }
> @@ -1533,14 +1535,18 @@ retry_rcvqfill:
> dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
> __func__);
> dev_err(dev, "skb[%p] PROBLEM\n", skb);
> - dev_err(dev, " skbdata[%p]\n", skb->data);
> + dev_err(dev, " skbdata[%p]\n",
> + skb->data);
> dev_err(dev, " skblen[%x]\n", skb->len);
> dev_err(dev, " paddr[%p]\n", paddr);
> dev_err(dev, " paddrl[%x]\n", paddrl);
> dev_err(dev, " paddrh[%x]\n", paddrh);
> - dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
> - dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
> - dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
> + dev_err(dev, " rcvq->head[%p]\n",
> + rcvq->head);
> + dev_err(dev, " rcvq->tail[%p]\n",
> + rcvq->tail);
> + dev_err(dev, " rcvq->count[%x]\n",
> + rcvq->count);
> dev_err(dev, "SKIP THIS SKB!!!!!!!!\n");
> goto retry_rcvqfill;
> }
> @@ -1549,14 +1555,18 @@ retry_rcvqfill:
> dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
> __func__);
> dev_err(dev, "skb[%p] PROBLEM\n", skb);
> - dev_err(dev, " skbdata[%p]\n", skb->data);
> + dev_err(dev, " skbdata[%p]\n",
> + skb->data);
> dev_err(dev, " skblen[%x]\n", skb->len);
> dev_err(dev, " paddr[%p]\n", paddr);
> dev_err(dev, " paddrl[%x]\n", paddrl);
> dev_err(dev, " paddrh[%x]\n", paddrh);
> - dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
> - dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
> - dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
> + dev_err(dev, " rcvq->head[%p]\n",
> + rcvq->head);
> + dev_err(dev, " rcvq->tail[%p]\n",
> + rcvq->tail);
> + dev_err(dev, " rcvq->count[%x]\n",
> + rcvq->count);
> dev_err(dev, "GIVE TO CARD ANYWAY\n");
> }
> #endif
> @@ -1885,7 +1895,8 @@ static void slic_xmit_fail(struct adapter *adapter,
> break;
> case XMIT_FAIL_HOSTCMD_FAIL:
> dev_err(&adapter->netdev->dev,
> - "xmit_start skb[%p] type[%x] No host commands available\n", skb, skb->pkt_type);
> + "xmit_start skb[%p] type[%x] No host commands available\n",
> + skb, skb->pkt_type);
> break;
> }
> }
> @@ -2097,7 +2108,8 @@ static void slic_interrupt_card_up(u32 isr, struct adapter *adapter,
> }
> } else if (isr & ISR_XDROP) {
> dev_err(&dev->dev,
> - "isr & ISR_ERR [%x] ISR_XDROP\n", isr);
> + "isr & ISR_ERR [%x] ISR_XDROP\n",
> + isr);
> } else {
> dev_err(&dev->dev,
> "isr & ISR_ERR [%x]\n",
> @@ -2341,7 +2353,8 @@ static int slic_if_init(struct adapter *adapter)
> SLIC_GET_ADDR_LOW(&pshmem->isr), FLUSH);
> #else
> slic_reg32_write(&slic_regs->slic_addr_upper, 0, DONT_FLUSH);
> - slic_reg32_write(&slic_regs->slic_isp, (u32)&pshmem->isr, FLUSH);
> + slic_reg32_write(&slic_regs->slic_isp, (u32)&pshmem->isr,
> + FLUSH);
> #endif
> spin_unlock_irqrestore(&adapter->bit64reglock.lock,
> adapter->bit64reglock.flags);
> --
> 2.1.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: slicoss: Fix long line issues in slicoss.c
@ 2014-12-03 13:53 Sean Cleator
2015-01-18 0:13 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Sean Cleator @ 2014-12-03 13:53 UTC (permalink / raw)
To: gregkh
Cc: Lior Dotan, Christopher Harrer, David Matlack, Monam Agarwal,
Paul E. McKenney, Joe Perches, Sean Cleator, Vincent Heuken,
devel, linux-kernel
A patch to the slicoss.c file to fix some of the long line issues found by the
checkpath.pl tool
Signed-off-by: Sean Cleator <seancleator@hotmail.co.uk>
---
drivers/staging/slicoss/slicoss.c | 39 ++++++++++++++++++++++++++-------------
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 56ca3b6..4df4a7e 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -498,12 +498,14 @@ static int slic_card_download(struct adapter *adapter)
slic_reg32_write(&slic_regs->slic_wcs,
baseaddress + codeaddr, FLUSH);
/* Write out instruction to low addr */
- slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
+ slic_reg32_write(&slic_regs->slic_wcs,
+ instruction, FLUSH);
instruction = *(u32 *)(fw->data + index);
index += 4;
/* Write out instruction to high addr */
- slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
+ slic_reg32_write(&slic_regs->slic_wcs,
+ instruction, FLUSH);
instruction = *(u32 *)(fw->data + index);
index += 4;
}
@@ -1533,14 +1535,18 @@ retry_rcvqfill:
dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
__func__);
dev_err(dev, "skb[%p] PROBLEM\n", skb);
- dev_err(dev, " skbdata[%p]\n", skb->data);
+ dev_err(dev, " skbdata[%p]\n",
+ skb->data);
dev_err(dev, " skblen[%x]\n", skb->len);
dev_err(dev, " paddr[%p]\n", paddr);
dev_err(dev, " paddrl[%x]\n", paddrl);
dev_err(dev, " paddrh[%x]\n", paddrh);
- dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
- dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
- dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
+ dev_err(dev, " rcvq->head[%p]\n",
+ rcvq->head);
+ dev_err(dev, " rcvq->tail[%p]\n",
+ rcvq->tail);
+ dev_err(dev, " rcvq->count[%x]\n",
+ rcvq->count);
dev_err(dev, "SKIP THIS SKB!!!!!!!!\n");
goto retry_rcvqfill;
}
@@ -1549,14 +1555,18 @@ retry_rcvqfill:
dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
__func__);
dev_err(dev, "skb[%p] PROBLEM\n", skb);
- dev_err(dev, " skbdata[%p]\n", skb->data);
+ dev_err(dev, " skbdata[%p]\n",
+ skb->data);
dev_err(dev, " skblen[%x]\n", skb->len);
dev_err(dev, " paddr[%p]\n", paddr);
dev_err(dev, " paddrl[%x]\n", paddrl);
dev_err(dev, " paddrh[%x]\n", paddrh);
- dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
- dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
- dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
+ dev_err(dev, " rcvq->head[%p]\n",
+ rcvq->head);
+ dev_err(dev, " rcvq->tail[%p]\n",
+ rcvq->tail);
+ dev_err(dev, " rcvq->count[%x]\n",
+ rcvq->count);
dev_err(dev, "GIVE TO CARD ANYWAY\n");
}
#endif
@@ -1885,7 +1895,8 @@ static void slic_xmit_fail(struct adapter *adapter,
break;
case XMIT_FAIL_HOSTCMD_FAIL:
dev_err(&adapter->netdev->dev,
- "xmit_start skb[%p] type[%x] No host commands available\n", skb, skb->pkt_type);
+ "xmit_start skb[%p] type[%x] No host commands available\n",
+ skb, skb->pkt_type);
break;
}
}
@@ -2097,7 +2108,8 @@ static void slic_interrupt_card_up(u32 isr, struct adapter *adapter,
}
} else if (isr & ISR_XDROP) {
dev_err(&dev->dev,
- "isr & ISR_ERR [%x] ISR_XDROP\n", isr);
+ "isr & ISR_ERR [%x] ISR_XDROP\n",
+ isr);
} else {
dev_err(&dev->dev,
"isr & ISR_ERR [%x]\n",
@@ -2341,7 +2353,8 @@ static int slic_if_init(struct adapter *adapter)
SLIC_GET_ADDR_LOW(&pshmem->isr), FLUSH);
#else
slic_reg32_write(&slic_regs->slic_addr_upper, 0, DONT_FLUSH);
- slic_reg32_write(&slic_regs->slic_isp, (u32)&pshmem->isr, FLUSH);
+ slic_reg32_write(&slic_regs->slic_isp, (u32)&pshmem->isr,
+ FLUSH);
#endif
spin_unlock_irqrestore(&adapter->bit64reglock.lock,
adapter->bit64reglock.flags);
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c
2014-12-03 13:53 [PATCH] Staging: slicoss: Fix long line issues in slicoss.c Sean Cleator
@ 2015-01-18 0:13 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-01-18 0:13 UTC (permalink / raw)
To: Sean Cleator
Cc: David Matlack, devel, Vincent Heuken, linux-kernel, Lior Dotan,
Christopher Harrer, Monam Agarwal, Joe Perches, Paul E. McKenney
On Wed, Dec 03, 2014 at 01:53:18PM +0000, Sean Cleator wrote:
> A patch to the slicoss.c file to fix some of the long line issues found by the
> checkpath.pl tool
>
> Signed-off-by: Sean Cleator <seancleator@hotmail.co.uk>
>
> ---
> drivers/staging/slicoss/slicoss.c | 39 ++++++++++++++++++++++++++-------------
> 1 file changed, 26 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 56ca3b6..4df4a7e 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -498,12 +498,14 @@ static int slic_card_download(struct adapter *adapter)
> slic_reg32_write(&slic_regs->slic_wcs,
> baseaddress + codeaddr, FLUSH);
> /* Write out instruction to low addr */
> - slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
> + slic_reg32_write(&slic_regs->slic_wcs,
> + instruction, FLUSH);
> instruction = *(u32 *)(fw->data + index);
> index += 4;
>
> /* Write out instruction to high addr */
> - slic_reg32_write(&slic_regs->slic_wcs, instruction, FLUSH);
> + slic_reg32_write(&slic_regs->slic_wcs,
> + instruction, FLUSH);
> instruction = *(u32 *)(fw->data + index);
> index += 4;
> }
> @@ -1533,14 +1535,18 @@ retry_rcvqfill:
> dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS == 0\n",
> __func__);
> dev_err(dev, "skb[%p] PROBLEM\n", skb);
> - dev_err(dev, " skbdata[%p]\n", skb->data);
> + dev_err(dev, " skbdata[%p]\n",
> + skb->data);
> dev_err(dev, " skblen[%x]\n", skb->len);
> dev_err(dev, " paddr[%p]\n", paddr);
> dev_err(dev, " paddrl[%x]\n", paddrl);
> dev_err(dev, " paddrh[%x]\n", paddrh);
> - dev_err(dev, " rcvq->head[%p]\n", rcvq->head);
> - dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
> - dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
> + dev_err(dev, " rcvq->head[%p]\n",
> + rcvq->head);
> + dev_err(dev, " rcvq->tail[%p]\n",
> + rcvq->tail);
> + dev_err(dev, " rcvq->count[%x]\n",
> + rcvq->count);
> dev_err(dev, "SKIP THIS SKB!!!!!!!!\n");
> goto retry_rcvqfill;
> }
This change makes the code look worse, don't you think? Please don't do
that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-18 0:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 13:53 [PATCH] Staging: slicoss: Fix long line issues in slicoss.c Sean Cleator
2015-01-18 0:13 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-12-02 23:45 Sean Cleator
2014-12-03 6:08 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox