public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>,
	Mitchel Humpherys <mitchelh@codeaurora.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ION handle already destroyed in ion_free.
Date: Sat, 17 Jan 2015 16:22:00 -0800	[thread overview]
Message-ID: <20150118002200.GA8609@kroah.com> (raw)
In-Reply-To: <1421476461-18070-1-git-send-email-shailendra.capricorn@gmail.com>

On Sat, Jan 17, 2015 at 12:04:21PM +0530, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 9e56d32..0d2b9a3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> 		if (IS_ERR(handle))
> 			return PTR_ERR(handle);
> 		ion_free(client, handle);
> -		ion_handle_put(handle);
> 		break;
> 	}
> 	case ION_IOC_SHARE:
> --
> 1.7.9.5

Are you sure about this?  Did you test it?  How?

thanks,

greg k-h

      reply	other threads:[~2015-01-18  0:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-17  6:34 [PATCH 2/2] ION handle already destroyed in ion_free Shailendra Verma
2015-01-18  0:22 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150118002200.GA8609@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitchelh@codeaurora.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=shailendra.capricorn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox