public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] ION handle already destroyed in ion_free.
@ 2015-01-17  6:34 Shailendra Verma
  2015-01-18  0:22 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Shailendra Verma @ 2015-01-17  6:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman, John Stultz, Mitchel Humpherys,
	Paul E. McKenney
  Cc: linux-kernel, Shailendra Verma


Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
 drivers/staging/android/ion/ion.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 9e56d32..0d2b9a3 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
		if (IS_ERR(handle))
			return PTR_ERR(handle);
		ion_free(client, handle);
-		ion_handle_put(handle);
		break;
	}
	case ION_IOC_SHARE:
--
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] ION handle already destroyed in ion_free.
  2015-01-17  6:34 [PATCH 2/2] ION handle already destroyed in ion_free Shailendra Verma
@ 2015-01-18  0:22 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2015-01-18  0:22 UTC (permalink / raw)
  To: Shailendra Verma
  Cc: John Stultz, Mitchel Humpherys, Paul E. McKenney, linux-kernel

On Sat, Jan 17, 2015 at 12:04:21PM +0530, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 9e56d32..0d2b9a3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> 		if (IS_ERR(handle))
> 			return PTR_ERR(handle);
> 		ion_free(client, handle);
> -		ion_handle_put(handle);
> 		break;
> 	}
> 	case ION_IOC_SHARE:
> --
> 1.7.9.5

Are you sure about this?  Did you test it?  How?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-18  0:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-17  6:34 [PATCH 2/2] ION handle already destroyed in ion_free Shailendra Verma
2015-01-18  0:22 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox