public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Milkovich <amilkovich@gmail.com>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Date: Sat, 17 Jan 2015 19:07:48 -0800	[thread overview]
Message-ID: <20150118030748.GA31575@kroah.com> (raw)
In-Reply-To: <20150118030141.GA1937@zenbook.hsd1.ca.comcast.net>

On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote:
> Hi,
> 
> On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote:
> > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote:
> > > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr
> > > comment is implied by the first argument being the channel. No parent bus
> > > comment is already understood by the argument being NULL.
> > > 
> > > Signed-off-by: Andrew Milkovich <amilkovich@gmail.com>
> > > ---
> > >  drivers/staging/unisys/virtpci/virtpci.c | 24 ++++++++----------------
> > >  1 file changed, 8 insertions(+), 16 deletions(-)
> > 
> > This doesn't apply to my staging-testing branch at all, sorry.
> > 
> > greg k-h
> 
> Processing the patch with 'git apply' complains about a corruption; this is due
> to the fact that I ran cleanfile on the patch. The checkpatch.pl script was
> giving errors about trailing whitespace. I ran cleanpatch, errors still showed
> up, I ran cleanfile and it passed.
> 
> Using 'patch -p1 < patchname' seems to work.

Doesn't work for me, try it against the branch above, I think it was due
to other changes in this driver in my tree.

If not, just resend, maybe I messed something up on my end, it has been
known to happen :)

thanks,

greg k-h

  reply	other threads:[~2015-01-18  3:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-17  4:58 [PATCH] Staging: unisys: virtpci: fixed coding style errors Andrew Milkovich
2015-01-18  0:22 ` Greg KH
2015-01-18  3:01   ` Andrew Milkovich
2015-01-18  3:07     ` Greg KH [this message]
2015-01-18  3:07   ` Andrew Milkovich
  -- strict thread matches above, loose matches on Subject: below --
2015-01-18  3:30 Andrew Milkovich
2015-01-18  4:01 ` Joe Perches
2015-01-18  4:14   ` Andrew Milkovich
2015-01-18  3:11 Andrew Milkovich
2015-01-25 11:47 ` Greg KH
2014-12-18  1:25 Andrew Milkovich
2015-01-10  1:41 ` Greg KH
2015-01-12 22:53   ` Andrew Milkovich
2015-01-12 23:03     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150118030748.GA31575@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amilkovich@gmail.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox