RE: [PATCH v18 04/12] input: cyapa: add runtime power management interfaces support for the device

Dudley Du
2015-01-19T01:52:24Z

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: 2015?1?18? 16:32
> To: Dudley Du
> Cc: jmmahler@gmail.com; rydberg@euromail.se; bleung@google.com;
> linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v18 04/12] input: cyapa: add runtime power management
> interfaces support for the device
>
> Hi Dudley,
>
> On Fri, Jan 16, 2015 at 02:34:07PM +0800, Dudley Du wrote:
>
> > +#ifdef CONFIG_PM_RUNTIME
> > +static ssize_t cyapa_show_rt_suspend_scanrate(struct device *dev,
> > + struct device_attribute *attr,
> > + char *buf)
>
> The runtime PM was switched to just CONFIG_PM in mainline and
> CONFIG_PM_RUNTIME was dropped. I adjusted the patch accordingly.

Thanks, I will update my knowledge.;)

>
> ...
>
> > -static SIMPLE_DEV_PM_OPS(cyapa_pm_ops, cyapa_suspend, cyapa_resume);
> > +#ifdef CONFIG_PM_RUNTIME
> > +static int cyapa_runtime_suspend(struct device *dev)
>
> I switched both cyapa_runtme_suspend and resume to __maybe_unused and
> dropped #ifdef guards.
>
> Thanks.
>
> --
> Dmitry

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.