Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support

Dmitry Torokhov
2015-01-19T00:26:40Z

On Fri, Jan 16, 2015 at 02:34:12PM +0800, Dudley Du wrote:
> + /* APP_INTEGRITY row is always the last row block,
> + * and the row id must be 0x01ff */
> + row_num = get_unaligned_be16(
> + &image->records[flash_records_count - 1].row_number);
> + if (image->records[flash_records_count - 1].flash_array_id != 0x00 &&
> + row_num != 0x01ff) {

By the way, shouldn't this be "or" and not "and"?

> + dev_err(dev, "%s: invalid app_integrity data.\n", __func__);
> + return -EINVAL;
> + }

Thanks.

--
Dmitry