From: Darren Hart <dvhart@infradead.org>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: mjg59@srcf.ucam.org, pali.rohar@gmail.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, A.Sloman@cs.bham.ac.uk,
computersforpeace@gmail.com
Subject: Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS
Date: Sun, 18 Jan 2015 10:08:21 -0800 [thread overview]
Message-ID: <20150118180821.GB56582@vmdeb7> (raw)
In-Reply-To: <9352624.oIKUSW0aDp@xps13>
On Wed, Jan 14, 2015 at 03:07:21PM +0100, Gabriele Mazzotta wrote:
> Hi,
>
> I decided to remove "als" from input_triggers and created a dedicated
> sysfs file for it. Having it there was wrong and misleading.
> I also updated the documentation to reflect this change and fixed the
> wrong description of als_setting, now used for als_enabled.
Given this is a significant functional change, as opposed to a bug fix, I'm
leaning toward reverting the original and adding back the corrected version to
3.20. I'm going to look at the total impact first - let me know if you have a
strong argument one way or the other.
>
> Is returning -ENODEV only when writing to als_enabled the right thing
> to do or should it be returned also when reading als_enabled?
Why would the als_enabled file exist if it would return ENODEV? If it shouldn't,
then returning ENODEV in both cases would be the right thing to do as there is
an error present.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-01-18 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 14:05 [PATCH] dell-laptop: use dedicated sysfs file for ALS Gabriele Mazzotta
2015-01-14 14:07 ` Gabriele Mazzotta
2015-01-18 18:08 ` Darren Hart [this message]
2015-01-18 18:34 ` Gabriele Mazzotta
2015-01-21 18:38 ` Darren Hart
2015-01-21 22:32 ` Gabriele Mazzotta
2015-01-18 17:52 ` Darren Hart
2015-02-10 9:36 ` Pali Rohár
2015-02-13 14:30 ` Gabriele Mazzotta
2015-02-18 19:09 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118180821.GB56582@vmdeb7 \
--to=dvhart@infradead.org \
--cc=A.Sloman@cs.bham.ac.uk \
--cc=computersforpeace@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox