Re: [PATCH 0/4] toshiba_acpi: Add support for USB Sleep functions

Darren Hart
2015-01-18T19:07:27Z

On Wed, Jan 14, 2015 at 02:40:17PM -0700, Azael Avalos wrote:
> The following patches add support to several USB Sleep functions
> found on newer Toshiba laptops, allowing to use th USB ports while
> the laptop is asleep or turned off.
>
> Azael Avalos (4):
> toshiba_acpi: Add support for USB Sleep and Charge function
> toshiba_acpi: Add support for USB Sleep functions under battery
> toshiba_acpi: Add support for USB Rapid Charge
> toshiba_acpi: Add support for USB Sleep and Music
>
> drivers/platform/x86/toshiba_acpi.c | 449 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 449 insertions(+)

Hi Azael,

Ignore my comments on input validation and error codes, you cover the former,
and the latter keeps the driver internally consistent. That only leaves the
Disable/Auto/Alternate values and a couple trivial formatting and typos to
address.

Thanks,