public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] toshiba_acpi: Add support for USB Sleep functions
Date: Sun, 18 Jan 2015 11:07:23 -0800	[thread overview]
Message-ID: <20150118190723.GH56582@vmdeb7> (raw)
In-Reply-To: <1421271621-8330-1-git-send-email-coproscefalo@gmail.com>

On Wed, Jan 14, 2015 at 02:40:17PM -0700, Azael Avalos wrote:
> The following patches add support to several USB Sleep functions
> found on newer Toshiba laptops, allowing to use th USB ports while
> the laptop is asleep or turned off.
> 
> Azael Avalos (4):
>   toshiba_acpi: Add support for USB Sleep and Charge function
>   toshiba_acpi: Add support for USB Sleep functions under battery
>   toshiba_acpi: Add support for USB Rapid Charge
>   toshiba_acpi: Add support for USB Sleep and Music
> 
>  drivers/platform/x86/toshiba_acpi.c | 449 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 449 insertions(+)

Hi Azael,

Ignore my comments on input validation and error codes, you cover the former,
and the latter keeps the driver internally consistent. That only leaves the
Disable/Auto/Alternate values and a couple trivial formatting and typos to
address.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center

      parent reply	other threads:[~2015-01-18 19:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 21:40 [PATCH 0/4] toshiba_acpi: Add support for USB Sleep functions Azael Avalos
2015-01-14 21:40 ` [PATCH 1/4] toshiba_acpi: Add support for USB Sleep and Charge function Azael Avalos
2015-01-18 18:46   ` Darren Hart
2015-01-18 18:55   ` Darren Hart
2015-01-14 21:40 ` [PATCH 2/4] toshiba_acpi: Add support for USB Sleep functions under battery Azael Avalos
2015-01-18 18:54   ` Darren Hart
2015-01-14 21:40 ` [PATCH 3/4] toshiba_acpi: Add support for USB Rapid Charge Azael Avalos
2015-01-18 19:00   ` Darren Hart
2015-01-14 21:40 ` [PATCH 4/4] toshiba_acpi: Add support for USB Sleep and Music Azael Avalos
2015-01-18 19:07 ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150118190723.GH56582@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=coproscefalo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox