public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Tang, Feng" <feng.tang@intel.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	John Stultz <john.stultz@linaro.org>,
	Colin Cross <ccross@android.com>,
	Heesub Shin <heesub.shin@samsung.com>,
	Mitchel Humpherys <mitchelh@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id function
Date: Mon, 19 Jan 2015 09:58:37 +0800	[thread overview]
Message-ID: <20150119015837.GA29138@kroah.com> (raw)
In-Reply-To: <A74E4C03C808B649AF1F11527F2D44140510FC7D@SHSMSX101.ccr.corp.intel.com>

On Mon, Jan 19, 2015 at 01:14:49AM +0000, Tang, Feng wrote:
> Hi Greg,
> 
> Thanks for your review.
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Sunday, January 18, 2015 8:04 AM
> > To: Tang, Feng
> > Cc: One Thousand Gnomes; John Stultz; Colin Cross; Heesub Shin; Mitchel
> > Humpherys; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id
> > function
> >
> > > >
> > > > On Sun,  4 Jan 2015 15:11:51 +0800
> > > > Feng Tang <feng.tang@intel.com> wrote:
> > > >
> > > > > There is user case that user only knows the ion_handle idand
> > > > > needs to get the physical addr and len. So add this wrapper to
> > > > > meet this requirement.
> > > >
> > > > What is the in-tree upstream user of this new function ? I don't see one
> > > > in your patches ?
> > >
> > > That's true. We are working on enabling a new platform which heavily
> > > uses ION and some driver needs to use this API, so I guess there is some
> > > other plaforms may have the similar requirements. If you think this patch
> > > should be merged after there is an in-tree user, I'm OK with it :)
> > >
> > > I assume that driver's author will start to push his drivers in batch soon.
> > 
> > We need to see those patches first, we can't add apis for no in-tree
> > user, otherwise they will just get ripped out.
> I see. I'll repost this patch after our "user" driver get merged.
> 
> How about the 2/2 patch, which improve the profiling info through
> debugfs?
> 	[PATCH 2/2] staging: android: ion: Add pss info for each ion_client

I don't see it in my queue anywhere, sorry, feel free to resend it.

thanks,

greg k-h

      reply	other threads:[~2015-01-19  2:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04  7:11 [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id function Feng Tang
2015-01-04  7:11 ` [PATCH 2/2] staging: android: ion: Add pss info for each ion_client Feng Tang
2015-01-05 14:24 ` [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id function One Thousand Gnomes
2015-01-05 15:51   ` Tang, Feng
2015-01-18  0:04     ` Greg KH
2015-01-19  1:14       ` Tang, Feng
2015-01-19  1:58         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150119015837.GA29138@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ccross@android.com \
    --cc=feng.tang@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=heesub.shin@samsung.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitchelh@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox