From: Dan Carpenter <dan.carpenter@oracle.com>
To: Robin Schroer <sulamiification@gmail.com>
Cc: Shirish Gajera <gajerashirish@gmail.com>,
devel@driverdev.osuosl.org, kirk@reisers.ca,
gregkh@linuxfoundation.org, daeseok.youn@gmail.com,
rusty@rustcorp.com.au, speakup@linux-speakup.org,
aysemelikeyurtoglu@gmail.com, linux-kernel@vger.kernel.org,
domagoj.trsan@gmail.com, roxanagabriela10@gmail.com,
tapaswenipathak@gmail.com, samuel.thibault@ens-lyon.org,
dilekuzulmez@gmail.com, ben@decadent.org.uk,
sasha.levin@oracle.com, chris@the-brannons.com
Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.
Date: Mon, 19 Jan 2015 15:19:34 +0300 [thread overview]
Message-ID: <20150119121934.GA6456@mwanda> (raw)
In-Reply-To: <20150118082921.GB1150@shodan.fritz.box>
On Sun, Jan 18, 2015 at 09:29:21AM +0100, Robin Schroer wrote:
> On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index e9f0c15..141abb7 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -422,8 +422,10 @@ static void announce_edge(struct vc_data *vc, int msg_id)
> > {
> > if (spk_bleeps & 1)
> > bleep(spk_y);
> > - if ((spk_bleeps & 2) && (msg_id < edge_quiet))
> > - synth_printf("%s\n", spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> > + if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> > + synth_printf("%s\n",
> > + spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
> > + }
> > }
> >
> You do not actually need to add the braces as this remains a single
> statement (mnemonic: without braces the if ends at the first semicolon).
>
In staging (and most other trees), we prefer that the curly braces be
there for multi-line indents. It makes it more readable.
regards,
dan carpenter
next prev parent reply other threads:[~2015-01-19 12:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 7:57 [PATCH] staging: speakup: Fix warning of line over 80 characters Shirish Gajera
2015-01-18 8:29 ` Robin Schroer
2015-01-19 12:19 ` Dan Carpenter [this message]
2015-01-18 9:55 ` Ben Hutchings
2015-01-19 12:25 ` Dan Carpenter
[not found] ` <CAG77vrrbEmw7OR8N7bcmKEkDwXonsfmJeE6-epYxSMLT5uQpMw@mail.gmail.com>
2015-01-19 20:26 ` Dan Carpenter
2015-01-19 12:23 ` Dan Carpenter
2015-01-25 11:37 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-03-28 20:21 Shirish Gajera
2015-03-28 20:40 ` Richard Weinberger
2015-03-28 21:18 ` Joe Perches
2015-03-28 21:22 ` Richard Weinberger
2015-03-28 21:35 ` Joe Perches
2015-03-28 23:44 ` Shirish Gajera
2015-03-28 23:54 ` Richard Weinberger
2015-03-29 0:26 ` Shirish Gajera
2015-03-29 9:28 ` Richard Weinberger
2015-03-30 6:17 ` Sudip Mukherjee
2015-03-30 7:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119121934.GA6456@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=ben@decadent.org.uk \
--cc=chris@the-brannons.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=domagoj.trsan@gmail.com \
--cc=gajerashirish@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=roxanagabriela10@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=samuel.thibault@ens-lyon.org \
--cc=sasha.levin@oracle.com \
--cc=speakup@linux-speakup.org \
--cc=sulamiification@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox