From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbbASOhF (ORCPT ); Mon, 19 Jan 2015 09:37:05 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:62181 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbbASOhD (ORCPT ); Mon, 19 Jan 2015 09:37:03 -0500 Date: Mon, 19 Jan 2015 23:37:38 +0900 From: Sergey Senozhatsky To: Hannes Reinecke Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] libata: fixup oops in ata_eh_link_report() Message-ID: <20150119143738.GA979@swordfish> References: <1421668859-4593-1-git-send-email-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421668859-4593-1-git-send-email-hare@suse.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (01/19/15 13:00), Hannes Reinecke wrote: > Date: Mon, 19 Jan 2015 13:00:59 +0100 > From: Hannes Reinecke > To: Tejun Heo > Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey > Senozhatsky , Hannes Reinecke > Subject: [PATCH] libata: fixup oops in ata_eh_link_report() > X-Mailer: git-send-email 1.8.5.2 > > We should only try to evaluate the cdb if this is an ATAPI > device, for any other device the 'cdb' field and the cdb_len > has no meaning. > > Signed-off-by: Hannes Reinecke > --- > drivers/ata/libata-eh.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > index 9179f11..584c6ae 100644 > --- a/drivers/ata/libata-eh.c > +++ b/drivers/ata/libata-eh.c > @@ -2481,8 +2481,6 @@ static void ata_eh_link_report(struct ata_link *link) > for (tag = 0; tag < ATA_MAX_QUEUE; tag++) { > struct ata_queued_cmd *qc = __ata_qc_from_tag(ap, tag); > struct ata_taskfile *cmd = &qc->tf, *res = &qc->result_tf; > - const u8 *cdb = qc->cdb; > - size_t cdb_len = qc->dev->cdb_len; > char data_buf[20] = ""; > char cdb_buf[70] = ""; > > @@ -2510,6 +2508,9 @@ static void ata_eh_link_report(struct ata_link *link) > } > > if (ata_is_atapi(qc->tf.protocol)) { > + const u8 *cdb = qc->cdb; > + size_t cdb_len = qd->dev->cdb_len; I think, it supposed to be qc, not qd. -ss > if (qc->scsicmd) { > cdb = qc->scsicmd->cmnd; > cdb_len = qc->scsicmd->cmd_len; > -- > 1.8.5.2 >