public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] drivers/usb/serial/mos7840.c: remove unused code
Date: Mon, 19 Jan 2015 16:00:14 +0100	[thread overview]
Message-ID: <20150119150014.GS30960@localhost> (raw)
In-Reply-To: <1421674378-14451-1-git-send-email-colin.king@canonical.com>

On Mon, Jan 19, 2015 at 01:32:58PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is old, unused code that is #defined out by the
> use of NOTMOS7840 and NOTMCS7840 - these are not
> defined anywhere.
> 
> If NOTMOS7840 is defined then the code will break on null
> pointer dereferences on mos7840_port.  So the code is
> currently unused, and broken anyway, so why not just
> remove it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks for the update. Applied for next now.

Johan

      reply	other threads:[~2015-01-19 15:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 13:32 [PATCH][V2] drivers/usb/serial/mos7840.c: remove unused code Colin King
2015-01-19 15:00 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150119150014.GS30960@localhost \
    --to=johan@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox