public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Mark Glover <mark@actisense.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added PIDs for Actisense USB Devices
Date: Mon, 19 Jan 2015 16:14:08 +0100	[thread overview]
Message-ID: <20150119151408.GT30960@localhost> (raw)
In-Reply-To: <1421310874-6754-1-git-send-email-mark@actisense.com>

On Thu, Jan 15, 2015 at 08:34:34AM +0000, Mark Glover wrote:
> From: Mark Glover <mark@actisense.com>
> 
> Signed-off-by: Mark Glover <mark@actisense.com>

Thanks for the patch and for addressing Peter's comments.

A couple of minor nits: Please use a subsystem prefix for your patch
summary, for example:

	"USB: ftdi_sio: add PIDs for Actisense devices"

You should also include a commit message (e.g. your current subject)
even if this is a simple patch.

You are adding both Actisense and Chetco product ids. How are these
related? Shouldn't the Chetco be under it's own heading (and be
mentioned in the commit log)?

And when resending, please include a "PATCH v4" prefix to make it easy
to track patch revisions.

Thanks,
Johan

  reply	other threads:[~2015-01-19 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15  8:34 [PATCH] Added PIDs for Actisense USB Devices Mark Glover
2015-01-19 15:14 ` Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-11 10:49 [PATCH] Added Pids for Actisense Usb Devices Mark Glover
2015-02-12  2:24 ` Johan Hovold
2015-02-12  8:46   ` Mark Glover
2015-02-12  9:42     ` Johan Hovold
2015-01-14 13:58 [PATCH] Added PIDs for Actisense USB Devices Mark Glover
2015-01-14 14:56 ` Peter Stuge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150119151408.GT30960@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark@actisense.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox