From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbbASU1o (ORCPT ); Mon, 19 Jan 2015 15:27:44 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:49931 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbbASU1n (ORCPT ); Mon, 19 Jan 2015 15:27:43 -0500 Date: Mon, 19 Jan 2015 23:26:38 +0300 From: Dan Carpenter To: shirish gajera Cc: Ben Hutchings , kirk@reisers.ca, Rusty Russell , Greg KH , DaeSeok Youn , Robin Schroer , speakup@linux-speakup.org, =?utf-8?Q?Ay=C5=9Fe_Melike_Yurto=C4=9Flu?= , linux-kernel@vger.kernel.org, Domagoj =?utf-8?B?VHLFoWFu?= , Roxana Blaj , tapaswenipathak@gmail.com, Samuel Thibault , Dilek =?iso-8859-1?Q?=DCz=FClmez?= , sasha.levin@oracle.com, Christopher Brannon Subject: Re: [PATCH] staging: speakup: Fix warning of line over 80 characters. Message-ID: <20150119202638.GC6507@mwanda> References: <20150118075753.GA2612@shirish-ThinkPad-Edge-E430> <1421574950.31046.97.camel@decadent.org.uk> <20150119122539.GC6456@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 19, 2015 at 12:00:34PM -0800, shirish gajera wrote: > I am confuse whether to wait till the patch got accepted or submit new > patch set. Just wait for Greg to get to the patch. We pretty much always apply long line fixes so just assume it's going to merged. > > Also, how to identify whether the corresponding warning is real or not ? It's all a matter of personal taste. The end code should look better than the original code. I thought your changes looked pretty good... regards, dan carpenter