From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819AbbATLBA (ORCPT ); Tue, 20 Jan 2015 06:01:00 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:38907 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbbATLA5 (ORCPT ); Tue, 20 Jan 2015 06:00:57 -0500 Date: Tue, 20 Jan 2015 11:00:45 +0000 From: Catalin Marinas To: Hanjun Guo Cc: "Rafael J. Wysocki" , Olof Johansson , Arnd Bergmann , Mark Rutland , "grant.likely@linaro.org" , Will Deacon , Lorenzo Pieralisi , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Mark Brown , Rob Herring , Robert Richter , Randy Dunlap , Charles Garcia-Tobin , "phoenix.liyi@huawei.com" , Timur Tabi , "suravee.suthikulpanit@amd.com" , "wangyijing@huawei.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64 Message-ID: <20150120110045.GD25575@e104818-lin.cambridge.arm.com> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-7-git-send-email-hanjun.guo@linaro.org> <20150116094913.GA13634@e104818-lin.cambridge.arm.com> <54BB51F1.8000900@linaro.org> <20150119104240.GE11835@e104818-lin.cambridge.arm.com> <54BDBFD4.7050207@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54BDBFD4.7050207@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 20, 2015 at 02:39:16AM +0000, Hanjun Guo wrote: > On 2015年01月19日 18:42, Catalin Marinas wrote: > > On Sun, Jan 18, 2015 at 06:25:53AM +0000, Hanjun Guo wrote: > >> On 2015年01月16日 17:49, Catalin Marinas wrote: > >>> On Wed, Jan 14, 2015 at 03:04:54PM +0000, Hanjun Guo wrote: > >>>> --- a/arch/arm64/kernel/pci.c > >>>> +++ b/arch/arm64/kernel/pci.c > >>>> @@ -10,6 +10,7 @@ > >>>> * > >>>> */ > >>>> > >>>> +#include > >>>> #include > >>>> #include > >>>> #include > >>>> @@ -68,3 +69,30 @@ void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent) > >>>> bus->domain_nr = domain; > >>>> } > >>>> #endif > >>>> + > >>>> +/* > >>>> + * raw_pci_read/write - Platform-specific PCI config space access. > >>>> + * > >>>> + * Default empty implementation. Replace with an architecture-specific setup > >>>> + * routine, if necessary. > >>>> + */ > >>>> +int raw_pci_read(unsigned int domain, unsigned int bus, > >>>> + unsigned int devfn, int reg, int len, u32 *val) > >>>> +{ > >>>> + return -EINVAL; > >>>> +} > >>>> + > >>>> +int raw_pci_write(unsigned int domain, unsigned int bus, > >>>> + unsigned int devfn, int reg, int len, u32 val) > >>>> +{ > >>>> + return -EINVAL; > >>>> +} > >>>> + > >>>> +#ifdef CONFIG_ACPI > >>>> +/* Root bridge scanning */ > >>>> +struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) > >>>> +{ > >>>> + /* TODO: Should be revisited when implementing PCI on ACPI */ > >>>> + return NULL; > >>>> +} > >>>> +#endif > > [...] > >>> When PCI is enabled and the above functions are compiled in, do they > >>> need to return any useful data or just -EINVAL. Are they ever called? > >> > >> They will be called if PCI root bridge is defined in DSDT, should I > >> print some warning message before it is implemented? > > > > My point: do they need to return real data when a PCI root bridge is > > defined in DSDT or you always expect them to always return some -E*? Can > > you explain why? > > Not always return -E* or NULL; > > For raw_pci_read/write(), they are needed to access the PCI config space > before the PCI root bus is created. so they will return 0 if access to > PCI config space is ok; pci_acpi_scan_root() will return root bus > pointer if it is successfully created. OK. So what's the plan for implementing these functions properly. For the raw_pci_read/write, the comment states "replace with an architecture-specific setup routine". What does this mean? For pci_acpi_scan_root(), at least the comment states a "TODO". Is there anyone working on this or we don't expect servers with PCIe soon? -- Catalin