From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294AbbATL4h (ORCPT ); Tue, 20 Jan 2015 06:56:37 -0500 Received: from mail-ie0-f179.google.com ([209.85.223.179]:48287 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbbATL4f (ORCPT ); Tue, 20 Jan 2015 06:56:35 -0500 Date: Tue, 20 Jan 2015 11:56:30 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/14] mfd: intel_soc_pmic: Constify struct regmap_config Message-ID: <20150120115630.GN13701@x1> References: <1420448493-9355-1-git-send-email-k.kozlowski@samsung.com> <1420448493-9355-3-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1420448493-9355-3-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote: > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/intel_soc_pmic_core.h | 2 +- > drivers/mfd/intel_soc_pmic_crc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/intel_soc_pmic_core.h b/drivers/mfd/intel_soc_pmic_core.h > index 33aacd9baddc..9498d6719847 100644 > --- a/drivers/mfd/intel_soc_pmic_core.h > +++ b/drivers/mfd/intel_soc_pmic_core.h > @@ -23,7 +23,7 @@ struct intel_soc_pmic_config { > unsigned long irq_flags; > struct mfd_cell *cell_dev; > int n_cell_devs; > - struct regmap_config *regmap_config; > + const struct regmap_config *regmap_config; > struct regmap_irq_chip *irq_chip; > }; > > diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c > index c85e2ecb868a..4cc1b324e971 100644 > --- a/drivers/mfd/intel_soc_pmic_crc.c > +++ b/drivers/mfd/intel_soc_pmic_crc.c > @@ -111,7 +111,7 @@ static struct mfd_cell crystal_cove_dev[] = { > }, > }; > > -static struct regmap_config crystal_cove_regmap_config = { > +static const struct regmap_config crystal_cove_regmap_config = { > .reg_bits = 8, > .val_bits = 8, > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog