From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754811AbbATMAJ (ORCPT ); Tue, 20 Jan 2015 07:00:09 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:32978 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753661AbbATMAG (ORCPT ); Tue, 20 Jan 2015 07:00:06 -0500 Date: Tue, 20 Jan 2015 11:59:59 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, Tony Lindgren , linux-omap@vger.kernel.org Subject: Re: [PATCH 13/14] mfd: twl-core: Constify struct regmap_config and reg_default array Message-ID: <20150120115959.GY13701@x1> References: <1420448493-9355-1-git-send-email-k.kozlowski@samsung.com> <1420448493-9355-13-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1420448493-9355-13-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote: > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. Make array of > struct reg_default const as well. > > Signed-off-by: Krzysztof Kozlowski > Cc: Tony Lindgren > Cc: linux-omap@vger.kernel.org > --- > drivers/mfd/twl-core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied with Tony's Ack, thanks. > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index db11b4f40611..489674a2497e 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -207,7 +207,7 @@ static struct twl_mapping twl4030_map[] = { > { 2, TWL5031_BASEADD_INTERRUPTS }, > }; > > -static struct reg_default twl4030_49_defaults[] = { > +static const struct reg_default twl4030_49_defaults[] = { > /* Audio Registers */ > { 0x01, 0x00}, /* CODEC_MODE */ > { 0x02, 0x00}, /* OPTION */ > @@ -306,7 +306,7 @@ static const struct regmap_access_table twl4030_49_volatile_table = { > .n_yes_ranges = ARRAY_SIZE(twl4030_49_volatile_ranges), > }; > > -static struct regmap_config twl4030_regmap_config[4] = { > +static const struct regmap_config twl4030_regmap_config[4] = { > { > /* Address 0x48 */ > .reg_bits = 8, > @@ -369,7 +369,7 @@ static struct twl_mapping twl6030_map[] = { > { 1, TWL6030_BASEADD_GASGAUGE }, > }; > > -static struct regmap_config twl6030_regmap_config[3] = { > +static const struct regmap_config twl6030_regmap_config[3] = { > { > /* Address 0x48 */ > .reg_bits = 8, > @@ -1087,7 +1087,7 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id) > struct twl4030_platform_data *pdata = dev_get_platdata(&client->dev); > struct device_node *node = client->dev.of_node; > struct platform_device *pdev; > - struct regmap_config *twl_regmap_config; > + const struct regmap_config *twl_regmap_config; > int irq_base = 0; > int status; > unsigned i, num_slaves; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog