From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbbATPnU (ORCPT ); Tue, 20 Jan 2015 10:43:20 -0500 Received: from mail-ie0-f182.google.com ([209.85.223.182]:59470 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbbATPnS (ORCPT ); Tue, 20 Jan 2015 10:43:18 -0500 Date: Tue, 20 Jan 2015 15:43:11 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v5 4/5] mfd/regulator: dt-bindings: max77686: Document gpio properties Message-ID: <20150120154311.GE13701@x1> References: <1420458525-22576-1-git-send-email-k.kozlowski@samsung.com> <1420458525-22576-5-git-send-email-k.kozlowski@samsung.com> <20150120134111.GI13701@x1> <1421763703.8855.10.camel@AMDC1943> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1421763703.8855.10.camel@AMDC1943> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jan 2015, Krzysztof Kozlowski wrote: > On wto, 2015-01-20 at 13:41 +0000, Lee Jones wrote: > > On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote: > > > > > Document usage of maxim,ena-gpios properties which turn on external/GPIO > > > control over regulator. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > Documentation/devicetree/bindings/mfd/max77686.txt | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt > > > index 75fdfaf41831..e39f0bc1f55e 100644 > > > --- a/Documentation/devicetree/bindings/mfd/max77686.txt > > > +++ b/Documentation/devicetree/bindings/mfd/max77686.txt > > > @@ -39,6 +39,12 @@ to get matched with their hardware counterparts as follow: > > > -BUCKn : 1-4. > > > Use standard regulator bindings for it ('regulator-off-in-suspend'). > > > > > > + LDO20, LDO21, LDO22, BUCK8 and BUCK9 can be configured to GPIO enable > > > + control. To turn this feature on this property must be added to the regulator > > > + sub-node: > > > + - maxim,ena-gpios : one GPIO specifier enable control (the gpio > > > + flags are actually ignored and always > > > + ACTIVE_HIGH is used) > > > > How does this differ to the 'enable-gpio' property which has already > > been defined? > > Strictly speaking - no difference, just a GPIO specifier. > > However the 'enable-gpio' property exists only for gpio-regulator. The > regulator core does not support generic enable-gpio property and each > driver implements it on its own. > > Anyway Mark Brown already applied this patch to his regulator tree. Well if he has no issue with it, then I guess I don't. > > > Example: > > > > > > @@ -65,4 +71,12 @@ Example: > > > regulator-always-on; > > > regulator-boot-on; > > > }; > > > + > > > + buck9_reg { > > > + regulator-compatible = "BUCK9"; > > > + regulator-name = "CAM_ISP_CORE_1.2V"; > > > + regulator-min-microvolt = <1000000>; > > > + regulator-max-microvolt = <1200000>; > > > + maxim,ena-gpios = <&gpm0 3 GPIO_ACTIVE_HIGH>; > > > + }; > > > } > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog