From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 0/4] mfd: reorganize Intel drivers
Date: Tue, 20 Jan 2015 15:46:44 +0000 [thread overview]
Message-ID: <20150120154644.GF13701@x1> (raw)
In-Reply-To: <1421763412.31903.70.camel@linux.intel.com>
On Tue, 20 Jan 2015, Andy Shevchenko wrote:
> On Tue, 2015-01-20 at 13:48 +0000, Lee Jones wrote:
> > On Thu, 11 Dec 2014, Andy Shevchenko wrote:
> >
> > > This patchset creates a new folder under drivers/mfd and moves there Intel
> > > related drivers.
> > >
> > > There is no functional change. The names of the kernel configuration variables
> > > are kept the same.
> >
> > Can you explain to me why you think the Intel drivers need their own
> > sub-directory please?
>
> For me it seems logical. We have many drivers related to Intel specific
> SoCs (in comparison the other mfd drivers that usually named in
> according to some standard chip codename) and they meanwhile have long
> awkward prefixes. Moreover they could share common dependencies like
> X86.
I'm not comfortable with it and am yet to see the need. What I would
suggest is to prefix 'intel-' or similar to the related files. From
there we can see how overbearing the files are becoming and make a
decision based on that.
If there are too many Intel related files, my first question(s) will
be a) why are there so many files b) are so many files required and c)
should they really live in MFD.
But as yet, this patch-set is the only indication that something needs
to be done at all.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-20 15:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 15:53 [PATCH v1 0/4] mfd: reorganize Intel drivers Andy Shevchenko
2014-12-11 15:53 ` [PATCH v1 1/4] mfd: change a layout for the Intel related drivers Andy Shevchenko
2015-01-20 12:33 ` Andy Shevchenko
2014-12-11 15:53 ` [PATCH v1 2/4] mfd: intel/lpc/sch: move driver to dedicated folder Andy Shevchenko
2014-12-11 15:53 ` [PATCH v1 3/4] mfd: intel/lpc/ich: " Andy Shevchenko
2014-12-11 15:53 ` [PATCH v1 4/4] mfd: intel/pmic: " Andy Shevchenko
2014-12-11 16:06 ` [PATCH v1 0/4] mfd: reorganize Intel drivers Joe Perches
2014-12-12 10:10 ` Andy Shevchenko
2014-12-12 10:15 ` Joe Perches
2014-12-30 19:29 ` Andy Shevchenko
2015-01-20 13:48 ` Lee Jones
2015-01-20 14:16 ` Andy Shevchenko
2015-01-20 15:46 ` Lee Jones [this message]
2015-01-20 16:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120154644.GF13701@x1 \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).