From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device
Date: Tue, 20 Jan 2015 16:55:27 +0000 [thread overview]
Message-ID: <20150120165527.GH30656@x1> (raw)
In-Reply-To: <54BE83FF.7030709@collabora.co.uk>
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote:
> Hello Lee,
>
> On 01/20/2015 05:29 PM, Lee Jones wrote:
> >
> > It's not a blocker, but it is a ridiculous name to use inside the
> > driver/ directory 'cos almost everything is a dev(ice) here.
> >
>
> Right, do you think that "cros-ec-chardev" will be a more suitable
> name? Sorry, I'm really bad at naming things...
But is it really a chardev? Don't chardevs usually live in
drivers/char? It probably uses a chardev node in /dev, but what does
it really do? What information can/will userspace obtain from this
memory block?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-20 16:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 13:32 [PATCH RESEND v2 0/7] platform/chrome: Add user-space dev inferface support Javier Martinez Canillas
2015-01-02 13:32 ` [PATCH RESEND v2 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC Javier Martinez Canillas
2015-01-20 7:48 ` Lee Jones
2015-01-20 15:40 ` Javier Martinez Canillas
2015-01-02 13:32 ` [PATCH RESEND v2 2/7] mfd: cros_ec: Add char dev and virtual dev pointers Javier Martinez Canillas
2015-01-20 7:50 ` Lee Jones
2015-01-20 15:41 ` Javier Martinez Canillas
2015-01-20 16:36 ` Lee Jones
2015-01-20 16:45 ` Javier Martinez Canillas
2015-01-20 16:51 ` Lee Jones
2015-01-02 13:32 ` [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices Javier Martinez Canillas
2015-01-20 8:11 ` Lee Jones
2015-01-20 15:58 ` Javier Martinez Canillas
2015-01-20 16:34 ` Lee Jones
2015-01-20 16:52 ` Javier Martinez Canillas
2015-01-21 17:05 ` Javier Martinez Canillas
2015-01-22 8:42 ` Lee Jones
2015-01-22 9:08 ` Javier Martinez Canillas
2015-01-22 9:46 ` Lee Jones
2015-01-22 10:36 ` Javier Martinez Canillas
2015-01-22 10:56 ` Lee Jones
2015-01-22 11:17 ` Javier Martinez Canillas
2015-01-02 13:32 ` [PATCH RESEND v2 4/7] platform/chrome: Add Chrome OS EC userspace device interface Javier Martinez Canillas
2015-01-13 23:40 ` Gwendal Grignou
2015-01-02 13:32 ` [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device Javier Martinez Canillas
2015-01-20 8:20 ` Lee Jones
2015-01-20 16:03 ` Javier Martinez Canillas
2015-01-20 16:29 ` Lee Jones
2015-01-20 16:36 ` Javier Martinez Canillas
2015-01-20 16:55 ` Lee Jones [this message]
2015-01-20 17:11 ` Javier Martinez Canillas
2015-01-21 16:56 ` Javier Martinez Canillas
2015-01-02 13:32 ` [PATCH RESEND v2 6/7] platform/chrome: Create sysfs attributes for the ChromeOS EC Javier Martinez Canillas
2015-01-02 13:32 ` [PATCH RESEND v2 7/7] platform/chrome: Expose Chrome OS Lightbar to users Javier Martinez Canillas
2015-01-12 10:18 ` [PATCH RESEND v2 0/7] platform/chrome: Add user-space dev inferface support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120165527.GH30656@x1 \
--to=lee.jones@linaro.org \
--cc=corbet@lwn.net \
--cc=dianders@chromium.org \
--cc=gwendal@google.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@google.com \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).