From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755626AbbATQ5Z (ORCPT ); Tue, 20 Jan 2015 11:57:25 -0500 Received: from mail-ie0-f175.google.com ([209.85.223.175]:58737 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755456AbbATQ5R (ORCPT ); Tue, 20 Jan 2015 11:57:17 -0500 Date: Tue, 20 Jan 2015 16:57:08 +0000 From: Lee Jones To: Charles Keepax Cc: Mark Brown , Inha Song , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data Message-ID: <20150120165708.GI30656@x1> References: <1420185829-24886-1-git-send-email-ideal.song@samsung.com> <1420185829-24886-3-git-send-email-ideal.song@samsung.com> <20150120122005.GA13701@x1> <20150120132001.GA21293@sirena.org.uk> <20150120160248.GK13701@x1> <20150120164418.GC14516@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150120164418.GC14516@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jan 2015, Charles Keepax wrote: > On Tue, Jan 20, 2015 at 04:02:48PM +0000, Lee Jones wrote: > > On Tue, 20 Jan 2015, Mark Brown wrote: > > > > > On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote: > > > > On Fri, 02 Jan 2015, Inha Song wrote: > > > > > > > > This patch update DT binding to support OUTn_MONO init_data. Each > > > > > output signal can be configurated as a mono differential output. > > > > > The mono differential configuration is selected using the OUTn_MONO > > > > > registers. > > > > > > > This requires a DT Ack and an entry in the example. > > > > > > The DT maintainers have said they're OK with maintainers just merging > > > things if they're comfortable with it (see the bindings specific > > > submitting-patches.txt) and given their workload and general resulting > > > responsiveness it's going to make it difficult go get anything done. > > > > I only tend to poke the DT guys when I am unsure of something in the > > binding. In this case it was a doubt whether we should be encoding > > register values inside a property like this. > > > > I would also be happy to take it with your Ack if you're happy with > > it? > > In this case really it is a boolean indicating if the > corresponding output is mono or not. It is handled thusly in the > code: > > if (arizona->pdata.out_mono[i]) > val = ARIZONA_OUT1_MONO; > else > val = 0; > > Perhaps some further wording tweaks on the Documentation patch > would be appropriate, but certainly I am happy enough with the > binding. Very well. As you and Mark seem happy with the approach I will be more lenient on the next submission. An example and some working tweaks would improve chances of acceptance further still. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog