From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbbAUELt (ORCPT ); Tue, 20 Jan 2015 23:11:49 -0500 Received: from mga11.intel.com ([192.55.52.93]:15110 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757AbbAUELr (ORCPT ); Tue, 20 Jan 2015 23:11:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,439,1418112000"; d="scan'208";a="640210074" Date: Wed, 21 Jan 2015 12:11:34 +0800 From: kbuild test robot To: Krzysztof Kozlowski Cc: kbuild-all@01.org, Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] power: max77693: fix simple_return.cocci warnings Message-ID: <20150121041134.GA205386@athens> References: <201501211232.F4NwbEWo%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201501211232.F4NwbEWo%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Krzysztof Kozlowski Signed-off-by: Fengguang Wu --- max77693_charger.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/power/max77693_charger.c +++ b/drivers/power/max77693_charger.c @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 if (ret) return ret; - ret = max77693_set_charge_input_threshold_volt(chg, + return max77693_set_charge_input_threshold_volt(chg, chg->charge_input_threshold_volt); - if (ret) - return ret; - - return 0; } #ifdef CONFIG_OF