Re: [PATCH] kernel: Conditionally support non-root users, groups and capabilities

[josh@joshtriplett.org]

On Wed, Jan 21, 2015 at 02:52:19PM +0000, One Thousand Gnomes wrote:
> The proposed patch generates a whole mass of ifdefs all over the place.
> If it's going to be done move all the functions in question together
> somewhere logical and give them a single ifdef or a file of their own.

I assume the header-file ifdefs are not problematic.  The functions in
kernel/sys.c are already grouped together in a single block and needed
only one ifdef.  So I'd assume the main problem is the multiple ifdefs
in capability.c and groups.c?  Might be possible to consolidate those,
sure.

> It also doesn't appear to be dropping all it should - why can't you
> simply not compile in groups.c for example ? If you can't then it says
> the patch is far from complete at this point.

Making groups.c entirely optional has been on the todo list for a while;
it's rather harder than just dropping the syscalls, as some of its
other functions are exported to the rest of the kernel as well, but it's
doable.

- Josh Triplett