From: Darren Hart <dvhart@infradead.org>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
platform-driver-x86@vger.kernel.org,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel@savoirfairelinux.com
Subject: Re: [PATCH v2 3/3] asus-laptop: cleanup is_visible
Date: Wed, 21 Jan 2015 10:19:55 -0800 [thread overview]
Message-ID: <20150121181955.GA7386@vmdeb7> (raw)
In-Reply-To: <810077082.264036.1421778036663.JavaMail.root@mail>
On Tue, Jan 20, 2015 at 01:20:36PM -0500, Vivien Didelot wrote:
> Hi Corentin,
>
> > > Use the attribute indexes and concise the if statements.
> > >
> > Why ? I really don't see that as an improvement.
>
> The improvement is code clarity and maintainability. I'm not use we want
> to keep multiple returns and this goto thing. I think per-attribute
> if-statements are clearer.
I have to concur with Corentin, changing to numerical indices rather than the
named atrributes makes the code harder to read in my opinion, and is more likely
to lead to mistakes than not.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-01-21 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 23:25 [PATCH v2 1/3] asus-laptop: fix is_visible return value Vivien Didelot
2015-01-18 23:25 ` [PATCH v2 2/3] asus-laptop: use DEVICE_ATTR_* macros Vivien Didelot
2015-01-21 18:28 ` Darren Hart
2015-01-21 20:19 ` Vivien Didelot
2015-01-22 16:26 ` Darren Hart
2015-01-18 23:25 ` [PATCH v2 3/3] asus-laptop: cleanup is_visible Vivien Didelot
2015-01-20 16:48 ` Corentin Chary
2015-01-20 18:20 ` Vivien Didelot
2015-01-21 18:19 ` Darren Hart [this message]
2015-01-21 18:25 ` [PATCH v2 1/3] asus-laptop: fix is_visible return value Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121181955.GA7386@vmdeb7 \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox