From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbbAVPaK (ORCPT ); Thu, 22 Jan 2015 10:30:10 -0500 Received: from mail.skyhub.de ([78.46.96.112]:50387 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752749AbbAVPaH (ORCPT ); Thu, 22 Jan 2015 10:30:07 -0500 Date: Thu, 22 Jan 2015 16:30:02 +0100 From: Borislav Petkov To: Boris Ostrovsky Cc: James Dingwall , linux-kernel@vger.kernel.org Subject: Re: Linux 3.18.2 / xen 4.4.1 dom0 - microcode oops Message-ID: <20150122153002.GA3554@pd.tnic> References: <20150122055242.GA11089@dingwall.me.uk> <20150122082003.GA3441@pd.tnic> <54C10DB6.2050708@oracle.com> <54C10ED0.1010302@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54C10ED0.1010302@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 22, 2015 at 09:53:04AM -0500, Boris Ostrovsky wrote: > Alternatively, we could return an error (-EINVAL?) from > microcode_init() when either of these two conditions is true. Yeah, this should be the right fix. James, does that fix your issue? (It should.) --- diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c index 15c29096136b..36a83617eb21 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -552,7 +552,7 @@ static int __init microcode_init(void) int error; if (paravirt_enabled() || dis_ucode_ldr) - return 0; + return -EINVAL; if (c->x86_vendor == X86_VENDOR_INTEL) microcode_ops = init_intel_microcode(); -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --