From: Christoph Hellwig <hch@infradead.org>
To: Yan Liu <yan@purestorage.com>
Cc: Matthew Wilcox <willy@linux.intel.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] NVMe: Do not take nsid while a passthrough IO command is being issued via a block device file descriptor
Date: Thu, 22 Jan 2015 23:57:08 -0800 [thread overview]
Message-ID: <20150123075708.GA17232@infradead.org> (raw)
In-Reply-To: <1421971328-5065-1-git-send-email-yan@purestorage.com>
On Thu, Jan 22, 2015 at 04:02:08PM -0800, Yan Liu wrote:
> When a passthrough IO command is issued with a specific block device file descriptor. It should be applied at
> the namespace which is associated with that block device file descriptor. This patch makes such passthrough
> command ignore nsid in nvme_passthru_cmd structure. Instead it takes the namespace ID asscoiated with the
> block device descriptor.
>
> Signed-off-by: Yan Liu <yan@purestorage.com>
Please move the code to find the ns into the caller, or even better a
seaprate helper used by the caller. instead of adding another argument to
nvme_user_cmd.
next prev parent reply other threads:[~2015-01-23 7:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 0:02 [PATCH 1/1] NVMe: Do not take nsid while a passthrough IO command is being issued via a block device file descriptor Yan Liu
2015-01-23 7:57 ` Christoph Hellwig [this message]
2015-01-23 16:22 ` Keith Busch
2015-01-23 17:27 ` Christoph Hellwig
2015-01-23 17:50 ` Keith Busch
2015-01-25 14:41 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-01-23 23:57 Yan Liu
2015-01-25 14:59 ` Christoph Hellwig
2015-01-26 18:02 ` Keith Busch
2015-01-22 0:28 Yan Liu
2015-01-22 0:47 ` Keith Busch
2015-01-22 8:45 ` Christoph Hellwig
2015-01-22 15:21 ` Keith Busch
2015-01-22 15:49 ` Christoph Hellwig
2015-01-22 16:58 ` Keith Busch
[not found] ` <CADMsRTZjajAj682a5FH-AmpphoQ4vw5QxqnJiGEQ+Jg_f7TvoA@mail.gmail.com>
2015-01-22 14:22 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123075708.GA17232@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=willy@linux.intel.com \
--cc=yan@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox