Re: [PATCH v2 4/5] xhci: Platform: Set Synopsis device disconnection quirk based on platform data

Felipe Balbi
2015-01-19T14:53:03Z

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

On Mon, Jan 19, 2015 at 03:56:48PM +0800, Sneeker Yeh wrote:
> If an xhci platform has Synopsis device disconnection errata then enable
> XHCI_DISCONNECT_QUIRK quirk flag.
>
> Signed-off-by: Sneeker Yeh <Sneeker.Yeh@tw.fujitsu.com>
> ---
> drivers/usb/host/xhci-plat.c | 3 +++
> include/linux/usb/xhci_pdriver.h | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 08d402b..40beb95 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -147,6 +147,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
> (pdata && pdata->usb3_lpm_capable))
> xhci->quirks |= XHCI_LPM_SUPPORT;
> +
> + if (pdata && pdata->delay_portcsc_clear)
> + xhci->quirks |= XHCI_DISCONNECT_QUIRK;
> /*
> * Set the xHCI pointer before xhci_plat_setup() (aka hcd_driver.reset)
> * is called by usb_add_hcd().
> diff --git a/include/linux/usb/xhci_pdriver.h b/include/linux/usb/xhci_pdriver.h
> index 376654b..a37a3a5 100644
> --- a/include/linux/usb/xhci_pdriver.h
> +++ b/include/linux/usb/xhci_pdriver.h
> @@ -18,10 +18,14 @@
> *
> * @usb3_lpm_capable: determines if this xhci platform supports USB3
> * LPM capability
> + * @delay_portcsc_clear: determines if Synopsis USB3 core has errata in
> + * "DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1" hardware
> + * configuration.
> *
> */
> struct usb_xhci_pdata {
> unsigned usb3_lpm_capable:1;
> + unsigned delay_portcsc_clear:1;

previous patch won't build before this is applied. That's a problem.
Please shuffle things around so that each and every patch builds and
works on its own.

We cannot break bisectability ;-)

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]