From: kbuild test robot <fengguang.wu@intel.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: kbuild-all@01.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] sched: completion: fix boolreturn.cocci warnings
Date: Sat, 24 Jan 2015 02:35:55 +0800 [thread overview]
Message-ID: <20150123183555.GA15416@waimea> (raw)
In-Reply-To: <201501240250.HuKROpUf%fengguang.wu@intel.com>
kernel/sched/completion.c:278:9-10: WARNING: return of 0/1 in function 'try_wait_for_completion' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
completion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sched/completion.c
+++ b/kernel/sched/completion.c
@@ -275,7 +275,7 @@ bool try_wait_for_completion(struct comp
* return early in the blocking case.
*/
if (!ACCESS_ONCE(x->done))
- return 0;
+ return false;
spin_lock_irqsave(&x->wait.lock, flags);
if (!x->done)
parent reply other threads:[~2015-01-23 18:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <201501240250.HuKROpUf%fengguang.wu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123183555.GA15416@waimea \
--to=fengguang.wu@intel.com \
--cc=der.herr@hofr.at \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox