From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755911AbbAWVZ2 (ORCPT ); Fri, 23 Jan 2015 16:25:28 -0500 Received: from down.free-electrons.com ([37.187.137.238]:53794 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751427AbbAWVZ0 (ORCPT ); Fri, 23 Jan 2015 16:25:26 -0500 Date: Fri, 23 Jan 2015 22:22:03 +0100 From: Maxime Ripard To: Priit Laes Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: sun4i: Add initial dts for Gemei G9 tablet Message-ID: <20150123212203.GB8470@lukather> References: <1422045409-1251-1-git-send-email-plaes@plaes.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qcHopEYAB45HaUaB" Content-Disposition: inline In-Reply-To: <1422045409-1251-1-git-send-email-plaes@plaes.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qcHopEYAB45HaUaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 23, 2015 at 10:36:49PM +0200, Priit Laes wrote: > Gemei G9 is an A10 based tablet, with 1G RAM, 16G NAND, 1024x768 > IPS LCD display, stereo speakers, 1.3MP front camera and 5 MP > rear camera, 8000mAh battery, GT901 2+1 touchscreen, Bosch BMA250 > accelerometer and RTL8188CUS USB wifi. It also has MicroSD slot, > miniHDMI, 1 x MicroUSB OTG port and 1 x MicroUSB host port and > 3.5mm headphone jack. > More details are available at: http://linux-sunxi.org/Gemei_G9 >=20 > Signed-off-by: Priit Laes > --- > arch/arm/boot/dts/Makefile | 6 +- > arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 138 +++++++++++++++++++++++++= ++++++ > 2 files changed, 142 insertions(+), 2 deletions(-) > create mode 100644 arch/arm/boot/dts/sun4i-a10-gemei-g9.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 7df26a2..a2e05fc 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -447,12 +447,14 @@ dtb-$(CONFIG_MACH_SUN4I) +=3D \ > sun4i-a10-ba10-tvbox.dtb \ > sun4i-a10-chuwi-v7-cw0825.dtb \ > sun4i-a10-cubieboard.dtb \ > + sun4i-a10-gemei-g9.dtb \ > + sun4i-a10-hackberry.dtb \ > + sun4i-a10-inet97fv2.dtb \ > sun4i-a10-marsboard.dtb \ > sun4i-a10-mini-xplus.dtb \ > sun4i-a10-mk802.dtb \ > sun4i-a10-mk802ii.dtb \ > - sun4i-a10-hackberry.dtb \ > - sun4i-a10-inet97fv2.dtb \ > + sun4i-a10-mini-xplus.dtb \ > sun4i-a10-olinuxino-lime.dtb \ > sun4i-a10-pcduino.dtb > dtb-$(CONFIG_MACH_SUN5I) +=3D \ > diff --git a/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts b/arch/arm/boot/dts= /sun4i-a10-gemei-g9.dts > new file mode 100644 > index 0000000..46700b8 > --- /dev/null > +++ b/arch/arm/boot/dts/sun4i-a10-gemei-g9.dts > @@ -0,0 +1,138 @@ > +/* > + * Copyright 2015 Priit Laes > + * > + * Priit Laes > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public > + * License along with this file; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > + * MA 02110-1301 USA > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun4i-a10.dtsi" > +#include "sunxi-common-regulators.dtsi" > +#include > + > +/ { > + model =3D "Gemei G9 Tablet"; > + compatible =3D "gemei,g9", "allwinner,sun4i-a10"; > +}; > + > +/* > + * http://linux-sunxi.org/Gemei_G9 Please don't put URL in the DT. This is very likely to change in the future, and won't be valid anymore. > + * > + * TODO: > + * 2x cameras via CSI > + * AXP battery management > + * AXP power enable key > + * Keys (LRADC) > + * NAND > + * OTG > + * Touchscreen - gt801_2plus1 @ i2c adapter 2 @ 0x48 > + */ > + > + > +&ehci0 { > + status =3D "okay"; > +}; Indentation with one tabulation please. > +&ehci1 { > + status =3D "okay"; > +}; > + > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins_a>; > + status =3D "okay"; > + > + axp209: pmic@34 { > + compatible =3D "x-powers,axp209"; > + reg =3D <0x34>; > + interrupts =3D <0>; > + > + interrupt-controller; > + #interrupt-cells =3D <1>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c1_pins_a>; > + status =3D "okay"; > + > + /* Accelerometer */ > + bma250@18 { > + compatible =3D "bosch,bma250"; > + reg =3D <0x18>; Is there a driver for this? It looks weird that it doesn't need more properties than that. > + }; > +}; > + > +®_usb1_vbus { > + status =3D "okay"; > +}; > + > +®_usb2_vbus { > + status =3D "okay"; > +}; > + > +&mmc0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>; > + vmmc-supply =3D <®_vcc3v3>; > + bus-width =3D <4>; > + cd-gpios =3D <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH01 */ > + cd-inverted; > + status =3D "okay"; > +}; > + > + Remove that extra new line. > +&uart0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&uart0_pins_a>; > + status =3D "okay"; > +}; > + > +&usbphy { > + usb1_vbus-supply =3D <®_usb1_vbus>; > + usb2_vbus-supply =3D <®_usb2_vbus>; > + status =3D "okay"; > +}; > --=20 > 2.2.2 >=20 Looks good otherwise, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --qcHopEYAB45HaUaB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUwrt7AAoJEBx+YmzsjxAgBuwP/RR7mqXcFKWWW7cX5gJRcrOV XGJSFeeh3X+XWnaeD7NMXV7hbwJ6R4w//r4EwkftdBr+TnbxPC4liBf+VGqW/9xb VRLpveXJZ/BgETahJ+DJYUF/dcOHmwVD0O25idvysBpPqFgfyAX9UvIWyrDFxTB+ LV05O4M751QsgaEiwjPaYVYVVbJm16DCVaJ4rwf4QHCKtot0AGB8/7kX0Kh9Y7Bi Co2l3pPBr5wKW6+7VPt0nFQnTpL49OlSD33MnlPjueLsyRxAvsi8l/ciP65c4GHH db/KQx9PKW1XPdhXD0P5g8OVpZ0V/XUjE4P4Q6h2ILqgC12OcbgjMR9Kv/E0ctbj JFjYh5HWOrdGdOJXvQPZSCvB1JezXFJ5RZbxYmznS59gkrnfI0rfHDQkoIzqcuGa gk/L9Xxgbyzr6LfhrTVMqwI+4CR7TFU/B4t6jGo+TMdVwTBXjhYnyVmYXdouzZ23 3hEMXYzB7TybyeZ3i3MNH+/OYetb+32+DJeDGW6HxlHd/lAE1olPH3qpiMMEqWct MD+P+0Otd9TqOYcig3XRhYnLJ9D/+UsCVLj5jMDPazbOViuhTBH92WIDNQfpOT64 fq+tkkVAmK8JDKpgfG8mTvJ5FAg9gs8CFllA1AQOOh17vsbSS1gNBSrsxccc4X+U QL1lfBq3O7UxXbViFYba =0+87 -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB--