From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753769AbbAWXtB (ORCPT ); Fri, 23 Jan 2015 18:49:01 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45347 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbbAWXs7 (ORCPT ); Fri, 23 Jan 2015 18:48:59 -0500 Date: Sat, 24 Jan 2015 00:48:55 +0100 From: Pavel Machek To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: linux-omap , Linux Kernel Mailing List , Aaro Koskinen , Tony Lindgren , Sebastian Reichel , Ivaylo Dimitrov , Russell King , linux-arm-kernel@lists.infradead.org, Laura Abbott Subject: Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken Message-ID: <20150123234855.GB27111@amd> References: <201501232239.55801@pali> <201501232336.36187@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201501232336.36187@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2015-01-23 23:36:36, Pali Rohár wrote: > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > Hello, > > > > when I boot zImage with appended DT n900 in qemu > > fdt_open_into() function called from file > > arch/arm/boot/compressed/atags_to_fdt.c (in function > > atags_to_fdt) always returns -FDT_ERR_NOSPACE. > > > > It means that all ATAGS (including cmdline arguments) passed > > by bootloader are ignored. > > > > On real n900 device I see that booted DT version also ignore > > cmdline arguments from bootloader. I cannot debug decompress > > code on real device, but I think it is same problem as in > > qemu. > > Looks like this quick patch is fixing above problem: So... something overruns stack, and bigger stack fixes it...? Pavel > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > index 68be901..4a7d75b 100644 > --- a/arch/arm/boot/compressed/head.S > +++ b/arch/arm/boot/compressed/head.S > @@ -268,7 +268,7 @@ restart: adr r0, LC0 > * area. No GOT fixup has occurred yet, but none of the > * code we're about to call uses any global variable. > */ > - add sp, sp, #0x10000 > + add sp, sp, #0x20000 > stmfd sp!, {r0-r3, ip, lr} > mov r0, r8 > mov r1, r6 > @@ -289,7 +289,7 @@ restart: adr r0, LC0 > bleq atags_to_fdt > > ldmfd sp!, {r0-r3, ip, lr} > - sub sp, sp, #0x10000 > + sub sp, sp, #0x20000 > #endif > > mov r8, r6 @ use the appended device tree > > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html