From: Jeff Epler <jepler@unpythonic.net>
To: Anshul Garg <aksgarg1989@gmail.com>
Cc: akpm@linux-foundation.org, Levente Kurusa <levex@linux.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
linux-kernel@vger.kernel.org,
"anshul.g@samsung.com" <anshul.g@samsung.com>
Subject: Re: [PATCH] lib/kstrtox.c clean kstrtoll function
Date: Sat, 24 Jan 2015 13:30:32 -0600 [thread overview]
Message-ID: <20150124193031.GG40116@unpythonic.net> (raw)
In-Reply-To: <CA+HOOsiP-uLJPJzn=24XiodaK89-y7Fy8oj+ALnbw4iHdtGR5A@mail.gmail.com>
On Fri, Jan 23, 2015 at 06:55:36PM +0530, Anshul Garg wrote:
> if (((long long)tmp < LLONG_MIN) || ((long long)tmp > LLONG_MAX) )
> + return -ERANGE;
This proposed code is still wrong (-ERANGE can never be returned by this
statement). It may be best to leave the code alone, rather than propose
more untested alternatives.
Jeff
prev parent reply other threads:[~2015-01-24 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aksgarg1989@gmai.com>
2015-01-22 13:54 ` [PATCH] lib/kstrtox.c clean kstrtoll function Anshul Garg
2015-01-22 17:25 ` Jeff Epler
2015-01-23 13:25 ` Anshul Garg
2015-01-24 19:30 ` Jeff Epler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150124193031.GG40116@unpythonic.net \
--to=jepler@unpythonic.net \
--cc=akpm@linux-foundation.org \
--cc=aksgarg1989@gmail.com \
--cc=anshul.g@samsung.com \
--cc=felipe.contreras@gmail.com \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).