public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: kbuild-all@01.org, David Airlie <airlied@linux.ie>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/nouveau/bar: fix simple_return.cocci warnings
Date: Sun, 25 Jan 2015 14:24:49 +0800	[thread overview]
Message-ID: <20150125062448.GA23499@waimea> (raw)
In-Reply-To: <201501251444.W2sR21oD%fengguang.wu@intel.com>

drivers/gpu/drm/nouveau/core/subdev/bar/base.c:132:5-8: WARNING: end returns can be simpified

 Simplify a trivial if-return sequence.  Possibly combine with a
 preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 base.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
@@ -129,10 +129,7 @@ nouveau_bar_create_(struct nouveau_objec
 	ret = nouveau_subdev_create_(parent, engine, oclass, 0, "BARCTL",
 				     "bar", length, pobject);
 	bar = *pobject;
-	if (ret)
-		return ret;
-
-	return 0;
+	return ret;
 }
 
 void

           reply	other threads:[~2015-01-25  6:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <201501251444.W2sR21oD%fengguang.wu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150125062448.GA23499@waimea \
    --to=fengguang.wu@intel.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox