From: Greg KH <gregkh@linuxfoundation.org>
To: mathieu.poirier@linaro.org
Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: vt6655: correcting function declaration sparse error
Date: Sun, 25 Jan 2015 19:39:59 +0800 [thread overview]
Message-ID: <20150125113959.GA22997@kroah.com> (raw)
In-Reply-To: <1421546666-21461-2-git-send-email-mathieu.poirier@linaro.org>
On Sat, Jan 17, 2015 at 07:04:23PM -0700, mathieu.poirier@linaro.org wrote:
> From: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/
> LD drivers/staging/vt6655/built-in.o
> CHECK drivers/staging/vt6655/device_main.c
> drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static?
> CC [M] drivers/staging/vt6655/device_main.o
>
> Function @vnt_init is only called by @vt6655_probe, in turn is declared "static".
> As sparse suggest, @vnt_init should very likely be declared static as well. At
> least nothing in the file indicate that it should be otherwise.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This whole series does not apply to my staging-next branch, of
staging.git, please refresh against it and resend if it is still needed
(hint, I don't think they all are...)
thanks,
greg k-h
next prev parent reply other threads:[~2015-01-25 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 2:04 [PATCH 0/4] staging: vt6655: fixing various sparse problems mathieu.poirier
2015-01-18 2:04 ` [PATCH 1/4] staging: vt6655: correcting function declaration sparse error mathieu.poirier
2015-01-25 11:39 ` Greg KH [this message]
2015-01-28 2:37 ` Mathieu Poirier
2015-01-18 2:04 ` [PATCH 2/4] staging: vt6655: removing dead function as reported by sparse mathieu.poirier
2015-01-18 2:04 ` [PATCH 3/4] staging: vt6655: fix wrong parameter " mathieu.poirier
2015-01-18 2:04 ` [PATCH 4/4] staging: vt6655: correcting parameter related sparse error mathieu.poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125113959.GA22997@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox