From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Surya Seetharaman <surya.seetharaman9@gmail.com>,
Keerthimai Janarthanan <keerthimaipb@gmail.com>,
Tina Johnson <tinajohnson.1234@gmail.com>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Fabio Falzoi <fabio.falzoi84@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rts5208: use msecs_to_jiffies for timeouts
Date: Sun, 25 Jan 2015 20:01:22 +0800 [thread overview]
Message-ID: <20150125120122.GA14049@kroah.com> (raw)
In-Reply-To: <1421997353-12781-1-git-send-email-der.herr@hofr.at>
On Fri, Jan 23, 2015 at 08:15:53AM +0100, Nicholas Mc Guire wrote:
> This is only an API consolidation and should make things more readable
>
> Converting milliseconds to jiffies by val * HZ / 1000 is technically
> not wrong but msecs_to_jiffies(val) is the cleaner solution and handles
> corner cases correctly.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> v2: typo in patch subject fixed - no change in actual patch
>
> This patch was only compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_RTS5208=m
>
> Patch is against 3.19.0-rc5 -next-20150122
>
> drivers/staging/rts5208/rtsx_transport.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
greg k-h
prev parent reply other threads:[~2015-01-25 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 7:15 [PATCH v2] staging: rts5208: use msecs_to_jiffies for timeouts Nicholas Mc Guire
2015-01-25 12:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125120122.GA14049@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=der.herr@hofr.at \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=keerthimaipb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=surya.seetharaman9@gmail.com \
--cc=tinajohnson.1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox