From: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
To: Heba Aamer <heba93aamer@gmail.com>
Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com,
thomas@grouk.net, tapaswenipathak@gmail.com,
gregkh@linuxfoundation.org,
rickard_strandqvist@spectrumdigital.se,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Date: Sun, 25 Jan 2015 16:14:20 +0200 [thread overview]
Message-ID: <20150125141420.GA4046@localhost.localdomain> (raw)
In-Reply-To: <20150124202053.GA1641@mohammed-Inspiron-3537>
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> netdev_info was used since it is a network subsystem
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 7d0d171..7748a75 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
> struct net_device *pnetdev;
> struct usb_device *udev;
>
> - printk(KERN_INFO "r8712u: Staging version\n");
> + netdev_info(pnetdev, "r8712u: Staging version\n");
I've applied your patch and there is one problem here, pnetdev is not initialized yet.
It's better to use pr_info for now.
Kind Regards,
Aya Saif El-yazal Mahfouz
> /* In this probe function, O.S. will provide the usb interface pointer
> * to driver. We have to increase the reference count of the usb device
> * structure by using the usb_get_dev function.
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2015-01-25 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 20:20 [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
2015-01-25 11:57 ` Greg KH
2015-01-26 12:30 ` Heba Aamer
2015-01-25 14:14 ` Aya Mahfouz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125141420.GA4046@localhost.localdomain \
--to=mahfouz.saif.elyazal@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heba93aamer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=sudipm.mukherjee@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=thomas@grouk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox