Re: [PATCH 3.18 105/183] [media] af9005: fix kernel panic on init if compiled without IR

Greg Kroah-Hartman
2015-01-25T22:01:29Z

On Sun, Jan 25, 2015 at 08:32:59PM +0100, Luca Olivetti wrote:
> El 25/01/15 a les 19:07, Greg Kroah-Hartman ha escrit:
> > 3.18-stable review patch. If anyone has any objections, please let me know.
>
> I don't have any objection apart from the description: IIRC the bug is
> triggered only if the kernel is compiled without module support.
> In any case I think that symbol_request should return NULL if the
> requested symbol is not available, either because the kernel has been
> compiled without module support or the required symbol is not provided
> by any module (though I think in the latter case it already works this
> way, at least it did at the time I wrote the driver).
> Or, as I said here
> https://lkml.org/lkml/2009/2/4/350
> maybe symbol_request isn't the correct approach to provide multiple,
> alternative, implementations.

The description is identical to what is in Linus's tree, so there's not
much I can do about it at this late point in time, sorry.

thanks,

greg k-h