From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbbAYVb4 (ORCPT ); Sun, 25 Jan 2015 16:31:56 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:53177 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbbAYVbw (ORCPT ); Sun, 25 Jan 2015 16:31:52 -0500 Date: Sun, 25 Jan 2015 13:31:49 -0800 From: Guenter Roeck To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hans Holmberg , Alexandre Courbot , Linus Walleij Subject: Re: [PATCH 3.10 25/50] gpiolib: of: Correct error handling in of_get_named_gpiod_flags Message-ID: <20150125213149.GA3313@roeck-us.net> References: <20150125180702.521559311@linuxfoundation.org> <20150125180703.970882239@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150125180703.970882239@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.54C560C8.0063,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 25, 2015 at 10:07:15AM -0800, Greg Kroah-Hartman wrote: > 3.10-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Hans Holmberg > > commit 7b8792bbdffdff3abda704f89c6a45ea97afdc62 upstream. > > of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases > where the gpio chip is available and the GPIO translation fails. > > This causes drivers to be re-probed erroneusly, and hides the > real problem(i.e. the GPIO number being out of range). > > Signed-off-by: Hans Holmberg > Reviewed-by: Alexandre Courbot > Signed-off-by: Linus Walleij > Signed-off-by: Greg Kroah-Hartman > This patch is causing several build failures. Error log: drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_find_and_xlate': drivers/gpio/gpiolib-of.c:50:3: error: implicit declaration of function 'ERR_PTR' since "#include " is missing in drivers/gpio/gpiolib-of.c in the 3.10 kernel. Guenter