Re: [PATCH -mm] slab: update_memcg_params: explicitly check that old array != NULL

Dan Carpenter
2015-01-26T10:23:35Z

On Mon, Jan 26, 2015 at 01:01:19PM +0300, Vladimir Davydov wrote:
> This warning is false-positive, because @old equals NULL iff
> @memcg_nr_cache_ids equals 0.

I don't see how it could be a false positive. The "old" pointer is
dereferenced inside the call to memset() so unless memset is a macro the
compiler isn't going to optimize the dereference away.

//----- test code

void frob(void *p){}

struct foo {
int *x, *y, *z;
};

int main(void)
{
struct foo *x = NULL;

frob(x->y);

return 0;
}

//---- end

If we compile with gcc test.c then it segfaults. With -02 the compiler
is able to tell that frob() is an empty function and it doesn't
segfault. In the kernel code, there is no way for the compiler to
optimize the memset() away so it will Oops.

regards,
dan carpenter