linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high
Date: Mon, 26 Jan 2015 13:11:42 +0100	[thread overview]
Message-ID: <20150126121142.GG30345@8bytes.org> (raw)
In-Reply-To: <20150123170243.GG22635@pd.tnic>

On Fri, Jan 23, 2015 at 06:02:43PM +0100, Borislav Petkov wrote:
> On Tue, Jan 06, 2015 at 03:51:14PM +0100, Joerg Roedel wrote:
> > From: Joerg Roedel <jroedel@suse.de>
> > 
> > When the crashkernel is loaded above 4GiB in memory the
> > first kernel only allocates 72MiB of low-memory for the DMA
> > requirements of the second kernel. On systems with many
> > devices this is not enough and causes device driver
> > initialization errors and failed crash dumps. Set this
> > default value to 256MiB to make sure there is enough memory
> 
> This upper limit of 256 looks arbitrary. Are we going to raise it a
> couple of years from now if it becomes insufficient then?

Yes, it is arbitrary. I am open for suggestions on what might be a
proper value to satisfy most systems.

> It probably won't be easy but is there some more reliable way to
> allocate enough memory for DMA on a say per-system basis or whatever...?
> Probably not but let me ask it anyway.

Well, there is no easy way. But we could collect information from the
loaded drivers on boot about how many dma-memory they allocate and base
our allocation on that. Or we solve it in user-space by some more
cleverness in creating the kernel command-line for crashkernel=high.

But besides that, I think the first two patches of this set make sense
anyway. I understand that the third one is debatable.


	Joerg


  reply	other threads:[~2015-01-26 12:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 14:51 [PATCH 0/3 v2] Fix kdump failures with crashkernel=high Joerg Roedel
2015-01-06 14:51 ` [PATCH 1/3] swiotlb: Warn on allocation failure in swiotlb_alloc_coherent Joerg Roedel
2015-01-23 17:04   ` Borislav Petkov
2015-01-26 11:49     ` Joerg Roedel
2015-01-06 14:51 ` [PATCH 2/3] x86, swiotlb: Try coherent allocations with __GFP_NOWARN Joerg Roedel
2015-01-23 17:03   ` Borislav Petkov
2015-01-26  3:22     ` Baoquan He
2015-01-26 11:54       ` Joerg Roedel
2015-01-06 14:51 ` [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Joerg Roedel
2015-01-23  8:44   ` Baoquan He
2015-01-26 12:07     ` Joerg Roedel
2015-02-01  8:41       ` Baoquan He
2015-02-04 14:10         ` Joerg Roedel
2015-02-09 12:20           ` Joerg Roedel
2015-02-13 15:34             ` Baoquan He
2015-02-13 22:28               ` Joerg Roedel
2015-02-14 11:44                 ` Baoquan He
2015-01-23 17:02   ` Borislav Petkov
2015-01-26 12:11     ` Joerg Roedel [this message]
2015-01-26 12:20       ` Borislav Petkov
2015-01-26 12:40         ` Joerg Roedel
2015-01-26 12:45           ` Borislav Petkov
2015-01-14 13:35 ` [PATCH 0/3 v2] Fix kdump failures with crashkernel=high Joerg Roedel
2015-01-19 19:26 ` Borislav Petkov
2015-02-14 10:58 ` Baoquan He
2015-02-14 16:11   ` Joerg Roedel
2015-06-02  8:54     ` Baoquan He
2015-06-02  9:08       ` Joerg Roedel
  -- strict thread matches above, loose matches on Subject: below --
2015-06-05 10:29 [PATCH 0/3 v3] " Joerg Roedel
2015-06-05 10:30 ` [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Joerg Roedel
2014-11-28 11:29 [PATCH 0/3] Fix kdump failures with crashkernel=high Joerg Roedel
2014-11-28 11:29 ` [PATCH 3/3] x86, crash: Allocate enough low-mem when crashkernel=high Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150126121142.GG30345@8bytes.org \
    --to=joro@8bytes.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jroedel@suse.de \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).